build(deps): Bump CUDA from 12.8 to 12.9 by simoneves · Pull Request #27074 · prestodb/presto

simoneves · 2026-02-03T19:31:50Z

Description

Motivation and Context

12.9 will soon be the minimum for latest CUDF, and has several compiler fixes.

Impact

None known.

Test Plan

Tested locally at NVIDIA.

Contributor checklist

Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.
If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

== NO RELEASE NOTE ==

Summary by Sourcery

Build:

Bump CUDA toolkit version from 12.8 to 12.9 in the CentOS dependency Dockerfile for native execution.

sourcery-ai · 2026-02-03T19:31:58Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CentOS dependency Dockerfile used for native execution to install CUDA 12.9 instead of CUDA 12.8 during the build image setup.

File-Level Changes

Change	Details	Files
Bump CUDA version used in the CentOS dependency Docker image from 12.8 to 12.9.	Adjust the build script RUN command to invoke install_cuda with version 12.9 instead of 12.8 Keep the rest of the adapter and clang setup sequence unchanged to minimize behavioral differences	`presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

linux-foundation-easycla · 2026-02-03T19:31:59Z

The committers listed above are authorized under a signed CLA.

✅ login: simoneves / name: Simon Eves (0999524, 56d00ef, 7e3ca46, e9c6c58)

sourcery-ai

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

steveburnett · 2026-02-03T20:14:02Z

When you have time, please sign the Presto CLA as mentioned in this comment.

simoneves · 2026-02-03T21:05:23Z

@steveburnett we have a corporate one. I have asked to be added.

bdice · 2026-02-03T21:06:00Z

I would like to make the CUDA version used in the dependencies image configurable as an argument to the Docker build.

For comparison, Velox can read $CUDA_VERSION in its setup-centos-adapters.sh script (source here), so creating a Docker image with a different CUDA version just means setting that environment variable.

We would like a similar degree of control over the CUDA version in Presto's dependencies image. It can have a default value of 12.9. Could we add that to this PR? Should be just a couple more lines of diff.

cc: @paul-aiyedun @mattgara @Avinash-Raj since we were discussing this exact topic today.

presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile

zoltan

LGTM, thank you Simon!

majetideepak · 2026-02-05T15:49:31Z

@bdice Any other comments for this PR?

bdice · 2026-02-05T18:42:32Z

@bdice Any other comments for this PR?

Nope, all good! Approved. I proposed a similar change in Velox: facebookincubator/velox#16234

karthikeyann · 2026-02-09T17:50:04Z

presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile

                 install_adapters && \
                 install_clang15 && \
-                 install_cuda 12.8) && \
+                 install_cuda ${CUDA_VERSION}) && \


@majetideepak @zoltan can we add install_ucx also by default here? It will help us avoid rebuild dependency image for ibm-research-preview branch again?

Related issue rapidsai/velox-testing#163 (comment)

Let's do this in a separate PR.

Created a separate PR #27118

majetideepak · 2026-02-09T19:53:19Z

@simoneves the CLA is still missing.

simoneves · 2026-02-09T22:41:46Z

@majetideepak I am told my name has now been (re-)added to this CLA. I don't know how long that takes to filter through.

simoneves · 2026-02-09T22:49:14Z

@majetideepak I had the CLA confirmation email about three hours ago. Perhaps the EasyCLA job just needs re-running on this PR (and the test one which also randomly failed)? I see no option to do that myself, though. Please advise.

bdice · 2026-02-10T07:50:10Z

@simoneves I clicked through the link for the failing "EasyCLA" check and it prompted me to fill an additional form or two. It recognized my corporate CLA but also forced me to sign an individual CLA on top of that. I think I am finally registered all the way. Please give that a shot when you're able.

Pull changes from PR prestodb#27074 Add UCX version used in ibm-research-preview branch

simoneves · 2026-02-10T16:29:20Z

@bdice OK I did that, and the CLA is cleared

Summary: We would like to make it easier to configure the CUDA version used in building Velox containers. This PR adds a `CUDA_VERSION` build arg to the adapters stage in `centos-multi.dockerfile` which allows overriding the CUDA version at build time. As before, it defaults to 12.9. This mirrors the approach in prestodb/presto#27074. Pull Request resolved: #16234 Reviewed By: kevinwilfong Differential Revision: D92988821 Pulled By: jainxrohit fbshipit-source-id: f9756fb577bbb8aa4b7d4b775b2cb1c806aa97ac

…ookincubator#16234) Summary: We would like to make it easier to configure the CUDA version used in building Velox containers. This PR adds a `CUDA_VERSION` build arg to the adapters stage in `centos-multi.dockerfile` which allows overriding the CUDA version at build time. As before, it defaults to 12.9. This mirrors the approach in prestodb/presto#27074. Pull Request resolved: facebookincubator#16234 Reviewed By: kevinwilfong Differential Revision: D92988821 Pulled By: jainxrohit fbshipit-source-id: f9756fb577bbb8aa4b7d4b775b2cb1c806aa97ac

Bump CUDA from 12.8 to 12.9

56d00ef

simoneves requested review from a team as code owners February 3, 2026 19:31

sourcery-ai bot reviewed Feb 3, 2026

View reviewed changes

majetideepak previously approved these changes Feb 3, 2026

View reviewed changes

Expose CUDA_VERSION as ENV, default 12.9

0999524

simoneves dismissed majetideepak’s stale review via 0999524 February 3, 2026 22:11

Undo auto-complete mistake

e9c6c58

bdice reviewed Feb 3, 2026

View reviewed changes

presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile Show resolved Hide resolved

Add ARG, per @bdice

7e3ca46

simoneves requested review from bdice and majetideepak February 3, 2026 23:35

bdice mentioned this pull request Feb 4, 2026

build(cuda): Add CUDA_VERSION build arg to adapters dockerfile facebookincubator/velox#16234

Closed

zoltan approved these changes Feb 4, 2026

View reviewed changes

mbrobbel mentioned this pull request Feb 4, 2026

build(native): Use cuda 12.9 in centos deps Dockerfile #27082

Closed

7 tasks

bdice approved these changes Feb 5, 2026

View reviewed changes

bdice mentioned this pull request Feb 5, 2026

Add --cuda-version option to build scripts rapidsai/velox-testing#214

Open

karthikeyann reviewed Feb 9, 2026

View reviewed changes

majetideepak approved these changes Feb 9, 2026

View reviewed changes

karthikeyann added a commit to karthikeyann/presto that referenced this pull request Feb 10, 2026

Add CUDA_VERSION argument to Dockerfile

06e17d8

Pull changes from PR prestodb#27074 Add UCX version used in ibm-research-preview branch

karthikeyann approved these changes Feb 10, 2026

View reviewed changes

majetideepak merged commit f345bc5 into prestodb:master Feb 10, 2026
112 of 113 checks passed

This was referenced Mar 31, 2026

docs: Add release notes for 0.297 unix280/presto#51

Closed

docs: Add release notes for 0.297 unix280/presto#52

Open

prestodb-ci mentioned this pull request Apr 1, 2026

docs: Add release notes for 0.297 #27484

Open

15 tasks

Conversation

simoneves commented Feb 3, 2026 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

linux-foundation-easycla bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

steveburnett commented Feb 3, 2026

Uh oh!

simoneves commented Feb 3, 2026

Uh oh!

bdice commented Feb 3, 2026

Uh oh!

Uh oh!

zoltan left a comment

Choose a reason for hiding this comment

Uh oh!

majetideepak commented Feb 5, 2026

Uh oh!

bdice commented Feb 5, 2026

Uh oh!

karthikeyann Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karthikeyann Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

majetideepak Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

karthikeyann Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

majetideepak commented Feb 9, 2026

Uh oh!

simoneves commented Feb 9, 2026

Uh oh!

simoneves commented Feb 9, 2026

Uh oh!

bdice commented Feb 10, 2026

Uh oh!

simoneves commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

simoneves commented Feb 3, 2026 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Feb 3, 2026 •

edited

Loading

linux-foundation-easycla bot commented Feb 3, 2026 •

edited

Loading

karthikeyann Feb 9, 2026 •

edited

Loading

karthikeyann Feb 10, 2026 •

edited

Loading