Skip to content

fix(build): Fix deps container dockerfile#27145

Merged
czentgr merged 1 commit intoprestodb:masterfrom
simoneves:simoneves/fix_deps_dockefile_ucx_typo
Feb 14, 2026
Merged

fix(build): Fix deps container dockerfile#27145
czentgr merged 1 commit intoprestodb:masterfrom
simoneves:simoneves/fix_deps_dockefile_ucx_typo

Conversation

@simoneves
Copy link
Copy Markdown
Contributor

@simoneves simoneves commented Feb 14, 2026

Description

PR #27118 broke this Dockerfile by leaving an extra closing parenthesis after ${CUDA_VERSION}.

Motivation and Context

Fixes build.

Impact

Fixes build.

Test Plan

None.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

== NO RELEASE NOTE ==

Summary by Sourcery

Bug Fixes:

  • Correct a syntax error in the CentOS dependency Dockerfile that prevented the build from running successfully.

@simoneves simoneves requested review from a team as code owners February 14, 2026 05:14
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes a syntax error in the CentOS dependency Dockerfile by removing an extra closing parenthesis in the CUDA installation command within a chained RUN statement.

File-Level Changes

Change Details Files
Correct chained RUN command syntax in the CentOS dependency Dockerfile to restore a working build image.
  • Remove the stray closing parenthesis after the CUDA installation command argument
  • Ensure CUDA and UCX installation commands are correctly grouped within the bash -c build sequence
presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@karthikeyann
Copy link
Copy Markdown
Contributor

@pramodsatya https://github.com/prestodb/presto/pull/27118/changes had a merge conflict resolution issue. This PR fixes it.

Copy link
Copy Markdown
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simoneves

@czentgr czentgr merged commit dae492a into prestodb:master Feb 14, 2026
116 of 118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants