build(native): Use cuda 12.9 in centos deps Dockerfile#27082
Closed
mbrobbel wants to merge 1 commit intoprestodb:masterfrom
Closed
build(native): Use cuda 12.9 in centos deps Dockerfile#27082mbrobbel wants to merge 1 commit intoprestodb:masterfrom
mbrobbel wants to merge 1 commit intoprestodb:masterfrom
Conversation
|
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the CentOS dependency Dockerfile used for presto-native-execution to install CUDA 12.9 instead of 12.8 while keeping the rest of the build and adapter setup unchanged. Flow diagram for CentOS dependency Dockerfile build with CUDA 12_9flowchart TD
A[Base image: CentOS] --> B[Create build directory]
B --> C[Clone velox repository]
C --> D[Run setup-centos-adapters.sh]
D --> E[install_adapters]
E --> F[install_clang15]
F --> G[install_cuda 12_9]
G --> H[Remove build directory]
H --> I[Expose CUDA binaries on PATH]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider extracting the CUDA version into a single build ARG or environment variable in the Dockerfile (or a shared script) so future version bumps don’t require touching multiple hard-coded values.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the CUDA version into a single build ARG or environment variable in the Dockerfile (or a shared script) so future version bumps don’t require touching multiple hard-coded values.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
|
I missed #27074. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump cuda install from 12.8 to 12.9 in
presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile.Motivation and Context
Impact
N/A
Test Plan
Tested via https://github.com/rapidsai/velox-testing
Contributor checklist
Release Notes
Summary by Sourcery
Build: