Skip to content

build(native): Use cuda 12.9 in centos deps Dockerfile#27082

Closed
mbrobbel wants to merge 1 commit intoprestodb:masterfrom
mbrobbel:presto-native-centos-deps-cuda-12.9
Closed

build(native): Use cuda 12.9 in centos deps Dockerfile#27082
mbrobbel wants to merge 1 commit intoprestodb:masterfrom
mbrobbel:presto-native-centos-deps-cuda-12.9

Conversation

@mbrobbel
Copy link
Copy Markdown

@mbrobbel mbrobbel commented Feb 4, 2026

Description

Bump cuda install from 12.8 to 12.9 in presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile.

Motivation and Context

Impact

N/A

Test Plan

Tested via https://github.com/rapidsai/velox-testing

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

== NO RELEASE NOTE ==

Summary by Sourcery

Build:

  • Bump CUDA version from 12.8 to 12.9 in the CentOS dependency Dockerfile used for native execution builds.

@mbrobbel mbrobbel requested review from a team as code owners February 4, 2026 16:17
@linux-foundation-easycla
Copy link
Copy Markdown

CLA Not Signed

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CentOS dependency Dockerfile used for presto-native-execution to install CUDA 12.9 instead of 12.8 while keeping the rest of the build and adapter setup unchanged.

Flow diagram for CentOS dependency Dockerfile build with CUDA 12_9

flowchart TD
    A[Base image: CentOS] --> B[Create build directory]
    B --> C[Clone velox repository]
    C --> D[Run setup-centos-adapters.sh]
    D --> E[install_adapters]
    E --> F[install_clang15]
    F --> G[install_cuda 12_9]
    G --> H[Remove build directory]
    H --> I[Expose CUDA binaries on PATH]
Loading

File-Level Changes

Change Details Files
Bump CUDA toolkit version used in the CentOS dependency image from 12.8 to 12.9.
  • Adjust the install_cuda invocation to request CUDA version 12.9 instead of 12.8.
  • Retain existing build steps for Velox adapters and Clang 15 while only changing the CUDA version parameter.
presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider extracting the CUDA version into a single build ARG or environment variable in the Dockerfile (or a shared script) so future version bumps don’t require touching multiple hard-coded values.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the CUDA version into a single build ARG or environment variable in the Dockerfile (or a shared script) so future version bumps don’t require touching multiple hard-coded values.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mbrobbel
Copy link
Copy Markdown
Author

mbrobbel commented Feb 4, 2026

I missed #27074. Closing this one.

@mbrobbel mbrobbel closed this Feb 4, 2026
@mbrobbel mbrobbel deleted the presto-native-centos-deps-cuda-12.9 branch February 4, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant