[native] Advance velox #25318

amitkdutta · 2025-06-13T17:18:09Z

== NO RELEASE NOTE ==

amitkdutta · 2025-06-13T18:36:26Z

Noisy aggregation issue is resolved. Current problem is protocol.

In file included from /__w/presto/presto/presto-native-execution/./presto_cpp/main/common/Exception.h:17:
/__w/presto/presto/presto-native-execution/./presto_cpp/presto_protocol/core/presto_protocol_core.h:698:3: error: unknown type name 'Lifespan'
  Lifespan lifespan = {};
  ^
/__w/presto/presto/presto-native-execution/./presto_cpp/presto_protocol/core/presto_protocol_core.h:717:8: error: use of undeclared identifier 'Lifespan'
  List<Lifespan> noMoreSplitsForLifespan = {};
       ^
/__w/presto/presto/presto-native-execution/./presto_cpp/presto_protocol/core/presto_protocol_core.h:798:3: error: unknown type name 'Block'
  Block valueBlock = {};
  ^
/__w/presto/presto/presto-native-execution/./presto_cpp/presto_protocol/core/presto_protocol_core.h:970:3: error: unknown type name 'OperatorInfo'
  OperatorInfo info = {};
  ^
/__w/presto/presto/presto-native-execution/./presto_cpp/presto_protocol/core/presto_protocol_core.h:983:3: error: unknown type name 'Lifespan'
  Lifespan lifespan = {};

CC: @vhsu14 @shangm2

aditi-pandit · 2025-06-13T19:42:19Z

@amitkdutta : There is a crash in FAILED: presto_cpp/main/types/tests/presto_to_velox_query_plan_test... We'll have to investigate this. I opened #25324

@yingsu00 @PingLiuPing

PrestoToVeloxConnector.cpp:(.text+0xa7b0): undefined reference to `vtable for facebook::velox::connector::hive::HiveConnectorSplit'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: presto_cpp/main/connectors/libpresto_connectors.a(PrestoToVeloxConnector.cpp.o): in function `facebook::presto::HivePrestoToVeloxConnector::toHiveColumns(std::vector<facebook::presto::protocol::hive::HiveColumnHandle, std::allocator<facebook::presto::protocol::hive::HiveColumnHandle> > const&, facebook::presto::TypeParser const&, bool&) const':
PrestoToVeloxConnector.cpp:(.text+0xb346): undefined reference to `typeinfo for facebook::velox::connector::hive::HiveColumnHandle'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: presto_cpp/main/connectors/libpresto_connectors.a(PrestoToVeloxConnector.cpp.o): in function `facebook::presto::HivePrestoToVeloxConnector::toVeloxInsertTableHandle(facebook::presto::protocol::CreateHandle const*, facebook::presto::TypeParser const&) const':
PrestoToVeloxConnector.cpp:(.text+0xb6e4): undefined reference to `vtable for facebook::velox::connector::hive::HiveInsertFileNameGenerator'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: PrestoToVeloxConnector.cpp:(.text+0xb852): undefined reference to `vtable for facebook::velox::connector::hive::HiveInsertTableHandle'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: presto_cpp/main/connectors/libpresto_connectors.a(PrestoToVeloxConnector.cpp.o): in function `facebook::presto::HivePrestoToVeloxConnector::toVeloxInsertTableHandle(facebook::presto::protocol::InsertHandle const*, facebook::presto::TypeParser const&) const':
PrestoToVeloxConnector.cpp:(.text+0xbc1e): undefined reference to `vtable for facebook::velox::connector::hive::HiveInsertFileNameGenerator'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: PrestoToVeloxConnector.cpp:(.text+0xbd86): undefined reference to `vtable for facebook::velox::connector::hive::HiveInsertTableHandle'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: presto_cpp/main/connectors/libpresto_connectors.a(PrestoToVeloxConnector.cpp.o): in function `facebook::presto::(anonymous namespace)::toHiveTableHandle(facebook::presto::protocol::TupleDomain<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const&, std::shared_ptr<facebook::presto::protocol::RowExpression> const&, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<facebook::presto::protocol::Column, std::allocator<facebook::presto::protocol::Column> > const&, facebook::presto::protocol::TableHandle const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&, facebook::presto::VeloxExprConverter const&, facebook::presto::TypeParser const&)':
PrestoToVeloxConnector.cpp:(.text+0xcd6f): undefined reference to `facebook::velox::connector::hive::HiveTableHandle::HiveTableHandle(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, std::unordered_map<facebook::velox::common::Subfield, std::unique_ptr<facebook::velox::common::Filter, std::default_delete<facebook::velox::common::Filter> >, std::hash<facebook::velox::common::Subfield>, std::equal_to<facebook::velox::common::Subfield>, std::allocator<std::pair<facebook::velox::common::Subfield const, std::unique_ptr<facebook::velox::common::Filter, std::default_delete<facebook::velox::common::Filter> > > > >, std::shared_ptr<facebook::velox::core::ITypedExpr const> const&, std::shared_ptr<facebook::velox::RowType const> const&, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&)'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: PrestoToVeloxConnector.cpp:(.text+0xd0bb): undefined reference to `facebook::velox::connector::hive::HiveTableHandle::HiveTableHandle(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, std::unordered_map<facebook::velox::common::Subfield, std::unique_ptr<facebook::velox::common::Filter, std::default_delete<facebook::velox::common::Filter> >, std::hash<facebook::velox::common::Subfield>, std::equal_to<facebook::velox::common::Subfield>, std::allocator<std::pair<facebook::velox::common::Subfield const, std::unique_ptr<facebook::velox::common::Filter, std::default_delete<facebook::velox::common::Filter> > > > >, std::shared_ptr<facebook::velox::core::ITypedExpr const> const&, std::shared_ptr<facebook::velox::RowType const> const&, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&)'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: presto_cpp/main/connectors/libpresto_connectors.a(PrestoToVeloxConnector.cpp.o): in function `facebook::velox::connector::hive::HiveColumnHandle::HiveColumnHandle(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, facebook::velox::connector::hive::HiveColumnHandle::ColumnType, std::shared_ptr<facebook::velox::Type const>, std::shared_ptr<facebook::velox::Type const>, std::vector<facebook::velox::common::Subfield, std::allocator<facebook::velox::common::Subfield> >, facebook::velox::connector::hive::HiveColumnHandle::ColumnParseParameters)':
PrestoToVeloxConnector.cpp:(.text._ZN8facebook5velox9connector4hive16HiveColumnHandleC2ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEENS3_10ColumnTypeESt10shared_ptrIKNS0_4TypeEESG_St6vectorINS0_6common8SubfieldESaISJ_EENS3_21ColumnParseParametersE[_ZN8facebook5velox9connector4hive16HiveColumnHandleC5ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEENS3_10ColumnTypeESt10shared_ptrIKNS0_4TypeEESG_St6vectorINS0_6common8SubfieldESaISJ_EENS3_21ColumnParseParametersE]+0x33): undefined reference to `vtable for facebook::velox::connector::hive::HiveColumnHandle'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: velox/velox/connectors/hive/iceberg/libvelox_hive_iceberg_splitreader.a(IcebergSplit.cpp.o): in function `facebook::velox::connector::hive::HiveConnectorSplit::HiveConnectorSplit(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, facebook::velox::dwio::common::FileFormat, unsigned long, unsigned long, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::optional<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::optional<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > > const&, std::optional<int>, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&, std::shared_ptr<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const&, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&, long, bool, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&, std::optional<facebook::velox::FileProperties>, std::optional<facebook::velox::connector::hive::RowIdProperties>, std::optional<facebook::velox::connector::hive::HiveBucketConversion> const&)':
IcebergSplit.cpp:(.text._ZN8facebook5velox9connector4hive18HiveConnectorSplitC2ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESB_NS0_4dwio6common10FileFormatEmmRKSt13unordered_mapIS9_St8optionalIS9_ESt4hashIS9_ESt8equal_toIS9_ESaISt4pairISA_SH_EEESG_IiERKSF_IS9_S9_SJ_SL_SaISM_ISA_S9_EEERKSt10shared_ptrIS9_ESX_lbSX_SG_INS0_14FilePropertiesEESG_INS2_15RowIdPropertiesEERKSG_INS2_20HiveBucketConversionEE[_ZN8facebook5velox9connector4hive18HiveConnectorSplitC5ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESB_NS0_4dwio6common10FileFormatEmmRKSt13unordered_mapIS9_St8optionalIS9_ESt4hashIS9_ESt8equal_toIS9_ESaISt4pairISA_SH_EEESG_IiERKSF_IS9_S9_SJ_SL_SaISM_ISA_S9_EEERKSt10shared_ptrIS9_ESX_lbSX_SG_INS0_14FilePropertiesEESG_INS2_15RowIdPropertiesEERKSG_INS2_20HiveBucketConversionEE]+0x98): undefined reference to `vtable for facebook::velox::connector::hive::HiveConnectorSplit'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: velox/velox/connectors/hive/iceberg/libvelox_hive_iceberg_splitreader.a(IcebergSplit.cpp.o): in function `facebook::velox::connector::hive::HiveConnectorSplit::~HiveConnectorSplit()':
IcebergSplit.cpp:(.text._ZN8facebook5velox9connector4hive18HiveConnectorSplitD2Ev[_ZN8facebook5velox9connector4hive18HiveConnectorSplitD5Ev]+0x12): undefined reference to `vtable for facebook::velox::connector::hive::HiveConnectorSplit'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: velox/velox/connectors/hive/iceberg/libvelox_hive_iceberg_splitreader.a(IcebergSplit.cpp.o):(.data.rel.ro._ZTIN8facebook5velox9connector4hive7iceberg16HiveIcebergSplitE[_ZTIN8facebook5velox9connector4hive7iceberg16HiveIcebergSplitE]+0x10): undefined reference to `typeinfo for facebook::velox::connector::hive::HiveConnectorSplit'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: velox/velox/connectors/hive/iceberg/libvelox_hive_iceberg_splitreader.a(IcebergSplit.cpp.o):(.data.rel.ro._ZTVN8facebook5velox9connector4hive7iceberg16HiveIcebergSplitE[_ZTVN8facebook5velox9connector4hive7iceberg16HiveIcebergSplitE]+0x10): undefined reference to `facebook::velox::connector::hive::HiveConnectorSplit::serialize() const'
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: velox/velox/connectors/hive/iceberg/libvelox_hive_iceberg_splitreader.a(IcebergSplit.cpp.o):(.data.rel.ro._ZTVN8facebook5velox9connector4hive7iceberg16HiveIcebergSplitE[_ZTVN8facebook5velox9connector4hive7iceberg16HiveIcebergSplitE]+0x28): undefined reference to `facebook::velox::connector::hive::HiveConnectorSplit::toString[abi:cxx11]() const'

amitkdutta · 2025-06-13T19:53:05Z

@aditi-pandit Thanks for looking in the unit test issue. I see a protocol issue also

-- Build files have been written to: /__w/presto/presto/presto-native-execution/_build/debug
ninja: Entering directory `_build/debug'
[1/37] Building CXX object presto_cpp/main/common/CMakeFiles/presto_exception.dir/Exception.cpp.o
FAILED: presto_cpp/main/common/CMakeFiles/presto_exception.dir/Exception.cpp.o 
ccache /usr/bin/clang++-15 -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DFOLLY_CFG_NO_COROUTINES -DFOLLY_HAVE_INT128_T=1 -DGFLAGS_IS_A_DLL=0 -DPRESTO_ENABLE_JWT -DPRESTO_ENABLE_REMOTE_FUNCTIONS -DVELOX_DISABLE_GOOGLETEST -I/__w/presto/presto/presto-native-execution/. -I/__w/presto/presto/presto-native-execution/velox -I/__w/presto/presto/presto-native-execution/velox/velox/external/xxhash -I/__w/presto/presto/presto-native-execution/_build/debug/velox -I/__w/presto/presto/presto-native-execution/_build/debug -isystem /usr/local/include/proxygen -isystem /usr/include/libdwarf-0 -mavx2 -mfma -mavx -mf16c -mlzcnt -mbmi2 -Wno-nullability-completeness -Wno-deprecated-declarations -Wreorder -Werror -g -std=gnu++17 -MD -MT presto_cpp/main/common/CMakeFiles/presto_exception.dir/Exception.cpp.o -MF presto_cpp/main/common/CMakeFiles/presto_exception.dir/Exception.cpp.o.d -o presto_cpp/main/common/CMakeFiles/presto_exception.dir/Exception.cpp.o -c /__w/presto/presto/presto-native-execution/presto_cpp/main/common/Exception.cpp
In file included from /__w/presto/presto/presto-native-execution/presto_cpp/main/common/Exception.cpp:15:
In file included from /__w/presto/presto/presto-native-execution/./presto_cpp/main/common/Exception.h:17:
/__w/presto/presto/presto-native-execution/./presto_cpp/presto_protocol/core/presto_protocol_core.h:698:3: error: unknown type name 'Lifespan'
  Lifespan lifespan = {};
  ^
/__w/presto/presto/presto-native-execution/./presto_cpp/presto_protocol/core/presto_protocol_core.h:717:8: error: use of undeclared identifier 'Lifespan'
  List<Lifespan> noMoreSplitsForLifespan = {};
       ^
/__w/presto/presto/presto-native-execution/./presto_cpp/presto_protocol/core/presto_protocol_core.h:798:3: error: unknown type name 'Block'
  Block valueBlock = {};
  ^
/__w/presto/presto/presto-native-execution/./presto_cpp/presto_protocol/core/presto_protocol_core.h:970:3: error: unknown type name 'OperatorInfo'
  OperatorInfo info = {};
  ^
/__w/presto/presto/presto-native-execution/./presto_cpp/presto_protocol/core/presto_protocol_core.h:983:3: error: unknown type name 'Lifespan'
  Lifespan lifespan = {};
  ^

https://github.com/prestodb/presto/actions/runs/15640238139/job/44065604713?pr=25318#step:17:236

Not sure what changed in the protocol.

aditi-pandit · 2025-06-13T19:59:48Z

@amitkdutta : That's a good signal. It not the same symbols in the test failures, but its mostly a protocol related issue than a connector or iceberg specific one.

ghelmling · 2025-06-13T20:18:55Z

@aditi-pandit The weird thing is that, taking the first error on the Lifespan reference, I don't see Lifespan references on line 698 of presto_protocol_core.h: https://github.com/prestodb/presto/blob/master/presto-native-execution/presto_cpp/presto_protocol/core/presto_protocol_core.h#L698

It's only defined on line 730 and referenced below. Looking at the code referenced in the error, it could be from line 755: https://github.com/prestodb/presto/blob/master/presto-native-execution/presto_cpp/presto_protocol/core/presto_protocol_core.h#L698

but that is after the struct definition.

amitkdutta · 2025-06-13T20:25:02Z

CC: @czentgr @imjalpreet

amitkdutta · 2025-06-13T20:58:49Z

@aditi-pandit Since this is not blocking willing to merge because new velox have some errors that will be needed quickly by @singcha . Opening an issue to track protocol problem

czentgr · 2025-06-13T21:51:19Z

@amitkdutta If we are willing to break the prestissimo build for a while then I suppose we can merge it. So we have two issues. more more urgent than the other. The symbols issue blocks any prestissimo testing. The protocol issue is likely of less importance right now compared to the symbol issue.

aditi-pandit · 2025-06-13T21:56:29Z

@amitkdutta If we are willing to break the prestissimo build for a while then I suppose we can merge it. So we have two issues. more more urgent than the other. The symbols issue blocks any prestissimo testing. The protocol issue is likely of less importance right now compared to the symbol issue.

@amitkdutta : Agree with Christian... I initially thought this was something iceberg specific... but on closer inspection it looks much deeper than that... Absolutely no prestissimo tests have run with this build. Thats not good.

aditi-pandit

Putting a hold until we resolve the test failures.

aditi-pandit · 2025-06-13T22:20:05Z

@czentgr : There are tons of changes in CmakeLists, other build artifacts in the new Velox code added in this PR.

Given the test failure I saw, I initially thought that this commit could be problematic...
facebookincubator/velox@d8ad283

But any other clues ?

czentgr · 2025-06-13T22:58:54Z

@aditi-pandit I have a fix for the symbol issue. Not sure exactly why, but explicitly adding the velox hive connector and tpch connector to the dependency list works. The symbols are in these libraries but somehow not added to the executable otherwise.
In general, the PrestoToVeloxProtocol provides a single function to the test but pulls in all kinds of symbols.

I've told @amitkdutta what to patch. So it can be done in his PR or we can merge the Velox update PR and I can make a separate fix PR.

aditi-pandit

Thanks Christian.

Removing hold to avoid this staying over the weekend.

As per @czentgr last comment, we can patch later if needed

czentgr · 2025-06-14T12:34:59Z

Superseded by #25326.

aditi-pandit · 2025-06-14T15:26:57Z

@czentgr moved Velox ahead in #25326.

amitkdutta requested a review from a team as a code owner June 13, 2025 17:18

prestodb-ci added the from:Meta PR from Meta label Jun 13, 2025

gggrace14 previously approved these changes Jun 13, 2025

View reviewed changes

aditi-pandit requested changes Jun 13, 2025

View reviewed changes

amitkdutta mentioned this pull request Jun 13, 2025

[native] Add native memory pool reclaimer priority #25325

Merged

aditi-pandit previously approved these changes Jun 13, 2025

View reviewed changes

[native] Advance velox

446bbe1

amitkdutta dismissed stale reviews from aditi-pandit and gggrace14 via 446bbe1 June 13, 2025 23:34

amitkdutta force-pushed the vel85 branch from 7a86076 to 446bbe1 Compare June 13, 2025 23:34

amitkdutta mentioned this pull request Jun 14, 2025

[native] Advance Velox #25326

Merged

6 tasks

gggrace14 self-requested a review June 14, 2025 01:47

gggrace14 approved these changes Jun 14, 2025

View reviewed changes

aditi-pandit closed this Jun 14, 2025

[native] Advance velox #25318

[native] Advance velox #25318

Uh oh!

Conversation

amitkdutta commented Jun 13, 2025

Uh oh!

amitkdutta commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aditi-pandit commented Jun 13, 2025

Uh oh!

amitkdutta commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aditi-pandit commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghelmling commented Jun 13, 2025

Uh oh!

amitkdutta commented Jun 13, 2025

Uh oh!

amitkdutta commented Jun 13, 2025

Uh oh!

czentgr commented Jun 13, 2025

Uh oh!

aditi-pandit commented Jun 13, 2025

Uh oh!

aditi-pandit left a comment

Choose a reason for hiding this comment

Uh oh!

aditi-pandit commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

czentgr commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aditi-pandit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

czentgr commented Jun 14, 2025

Uh oh!

aditi-pandit commented Jun 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

amitkdutta commented Jun 13, 2025 •

edited

Loading

amitkdutta commented Jun 13, 2025 •

edited

Loading

aditi-pandit commented Jun 13, 2025 •

edited

Loading

aditi-pandit commented Jun 13, 2025 •

edited

Loading

czentgr commented Jun 13, 2025 •

edited

Loading

aditi-pandit left a comment •

edited

Loading