Skip to content

[native] Advance velox#25315

Closed
amitkdutta wants to merge 1 commit intoprestodb:masterfrom
amitkdutta:vel78
Closed

[native] Advance velox#25315
amitkdutta wants to merge 1 commit intoprestodb:masterfrom
amitkdutta:vel78

Conversation

@amitkdutta
Copy link
Contributor

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

@amitkdutta amitkdutta requested a review from a team as a code owner June 13, 2025 15:51
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jun 13, 2025
@amitkdutta amitkdutta marked this pull request as draft June 13, 2025 15:51
@amitkdutta
Copy link
Contributor Author

amitkdutta commented Jun 13, 2025

/__w/presto/presto/presto-native-execution/velox/velox/functions/prestosql/aggregates/NoisyCountIfGaussianAggregate.cpp:157:36: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-const-int-float-conversion]
          VELOX_CHECK_LE(rawNoise, std::numeric_limits<int64_t>::max());

facebookincubator/velox#13761 is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants