Skip to content

[native] Advance Velox#25326

Merged
amitkdutta merged 1 commit intoprestodb:masterfrom
czentgr:cz_update_velox
Jun 14, 2025
Merged

[native] Advance Velox#25326
amitkdutta merged 1 commit intoprestodb:masterfrom
czentgr:cz_update_velox

Conversation

@czentgr
Copy link
Contributor

@czentgr czentgr commented Jun 13, 2025

Had to fix:

  • new location for license check. This caused the protocol files
    to be incorrectly generated (aborted processing)
  • missing symbols in a atest, explicitly adding the libraries that
    contain them fixes the issue

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jun 13, 2025
Had to fix:
- new location for license check. This caused the protocol files
to be incorrectly generated (aborted processing)
- missing symbols in a atest, explicitly adding the libraries that
contain them fixes the issue
@czentgr czentgr marked this pull request as ready for review June 14, 2025 00:06
@czentgr czentgr requested a review from a team as a code owner June 14, 2025 00:06
@prestodb-ci prestodb-ci requested review from a team, Dilli-Babu-Godari and wanglinsong and removed request for a team June 14, 2025 00:06
@amitkdutta
Copy link
Contributor

Thanks @czentgr so much for jumping in so quickly and fixing all these.

Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @czentgr. This is amazing.

@amitkdutta
Copy link
Contributor

[prestocpp-linux-build-and-unit-test / prestocpp-linux-build-for-test (pull_request)] passed in #25318 :D

@amitkdutta
Copy link
Contributor

[prestocpp-linux-build-and-unit-test / prestocpp-linux-build-for-test (pull_request)] passed in #25318 :D

Retry passed 👯‍♂️

@czentgr
Copy link
Contributor Author

czentgr commented Jun 14, 2025

@amitkdutta nice yours also passed. So we can go with this PR once all the requirements pass. I'll keep an eye on it and merge asap.

@amitkdutta amitkdutta merged commit c26cb2d into prestodb:master Jun 14, 2025
120 of 121 checks passed
@czentgr czentgr deleted the cz_update_velox branch June 14, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants