Merged
Conversation
Had to fix: - new location for license check. This caused the protocol files to be incorrectly generated (aborted processing) - missing symbols in a atest, explicitly adding the libraries that contain them fixes the issue
Contributor
|
Thanks @czentgr so much for jumping in so quickly and fixing all these. |
amitkdutta
approved these changes
Jun 14, 2025
aditi-pandit
approved these changes
Jun 14, 2025
Contributor
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks @czentgr. This is amazing.
Contributor
|
|
Contributor
Retry passed 👯♂️ |
Contributor
Author
|
@amitkdutta nice yours also passed. So we can go with this PR once all the requirements pass. I'll keep an eye on it and merge asap. |
This was referenced Jun 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to fix:
to be incorrectly generated (aborted processing)
contain them fixes the issue
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes