[native] changes in ProtocolToThrift files based on IDL change#25308
Merged
vhsu14 merged 1 commit intoprestodb:masterfrom Jun 17, 2025
Merged
[native] changes in ProtocolToThrift files based on IDL change#25308vhsu14 merged 1 commit intoprestodb:masterfrom
vhsu14 merged 1 commit intoprestodb:masterfrom
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D76545874 |
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D76545874 |
vhsu14
added a commit
to vhsu14/presto
that referenced
this pull request
Jun 12, 2025
…odb#25308) Summary: Pull Request resolved: prestodb#25308 IDL changes for TimeZoneKey and HostAddress in prestodb#25292 to address prestodb#25287 Rollback Plan: Differential Revision: D76545874
…odb#25308) Summary: Pull Request resolved: prestodb#25308 IDL changes for TimeZoneKey and HostAddress in prestodb#25292 to address prestodb#25287 Rollback Plan: Differential Revision: D76545874
gggrace14
approved these changes
Jun 17, 2025
zoltan
pushed a commit
to zoltan/presto
that referenced
this pull request
Jun 18, 2025
…odb#25308) ## Description Make relevant changes in cpp based on IDL changes for TimeZoneKey and HostAddress in prestodb#25292 to address prestodb#25287 ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan Verifier (227811) ## Contributor checklist - [x] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [x] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [x] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [x] Adequate tests were added if applicable. - [x] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
6 tasks
anandamideShakyan
pushed a commit
to anandamideShakyan/presto
that referenced
this pull request
Jun 19, 2025
…odb#25308) ## Description Make relevant changes in cpp based on IDL changes for TimeZoneKey and HostAddress in prestodb#25292 to address prestodb#25287 ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan Verifier (227811) ## Contributor checklist - [x] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [x] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [x] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [x] Adequate tests were added if applicable. - [x] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
This was referenced Jul 4, 2025
This was referenced Jul 24, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make relevant changes in cpp based on IDL changes for TimeZoneKey and HostAddress in #25292 to address #25287
Motivation and Context
Impact
Test Plan
Verifier (227811)
Contributor checklist
Release Notes