Skip to content

[native] changes in ProtocolToThrift files based on IDL change #25308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vhsu14 merged 1 commit into from
Jun 17, 2025
Merged

[native] changes in ProtocolToThrift files based on IDL change #25308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions presto-native-execution/presto_cpp/main/tests/TaskStatusTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,7 @@ TEST_F(TaskStatusTest, executionFailureInfoOptionalFieldsEmpty) {

ASSERT_EQ(thriftExecutionFailureInfo.type(), "type");
ASSERT_EQ(thriftExecutionFailureInfo.errorLocation()->columnNumber(), 2);
ASSERT_EQ(thriftExecutionFailureInfo.remoteHost()->host(), "localhost");
ASSERT_EQ(thriftExecutionFailureInfo.remoteHost()->port(), 8080);
ASSERT_EQ(thriftExecutionFailureInfo.remoteHost()->hostPortString(), "localhost:8080");
ASSERT_EQ(thriftExecutionFailureInfo.errorCode()->type(), facebook::presto::thrift::ErrorType::INTERNAL_ERROR);
ASSERT_EQ(thriftExecutionFailureInfo.errorCode()->retriable(), false);
ASSERT_EQ(thriftExecutionFailureInfo.errorCause(), facebook::presto::thrift::ErrorCause::EXCEEDS_BROADCAST_MEMORY_LIMIT);
Expand Down
15 changes: 4 additions & 11 deletions presto-native-execution/presto_cpp/main/thrift/ProtocolToThrift.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions presto-native-execution/presto_cpp/main/thrift/presto_protocol-to-thrift-json.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,16 @@ WrapperStruct:
TransactionId:
RuntimeStats:
SqlFunctionId:
HostAddress:
TimeZoneKey:

Special:
HostAddress:
QualifiedObjectName:
MetadataUpdatesWrapper:
OperatorInfoUnion:
OutputBufferId:
SplitWrapper:
TableWriteInfoWrapper:
TaskId:
TimeZoneKey:
Type:
TypeSignature:
6 changes: 2 additions & 4 deletions presto-native-execution/presto_cpp/main/thrift/presto_thrift.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,7 @@ struct ErrorLocation {
2: i32 columnNumber;
}
struct HostAddress {
1: string host;
2: i32 port;
1: string hostPortString;
}
struct StageId {
1: string queryId;
Expand Down Expand Up @@ -237,8 +236,7 @@ struct TransactionId {
1: string uuid;
}
struct TimeZoneKey {
1: string id;
2: i16 key;
1: i16 timeZoneKey;
}
struct ResourceEstimates {
1: optional double executionTime;
Expand Down
28 changes: 0 additions & 28 deletions presto-native-execution/presto_cpp/main/thrift/special/HostAddress.cpp.inc
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions presto-native-execution/presto_cpp/main/thrift/special/TimeZoneKey.cpp.inc
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/thrift/thrift2json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/Library/Developer/CommandLineTools/usr/bin/python3
#!/usr/bin/env python3
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Expand Down
Loading