Skip to content

Update drift annotation#25292

Merged
shangm2 merged 1 commit intoprestodb:masterfrom
shangm2:idlUpdate
Jun 12, 2025
Merged

Update drift annotation#25292
shangm2 merged 1 commit intoprestodb:masterfrom
shangm2:idlUpdate

Conversation

@shangm2
Copy link
Contributor

@shangm2 shangm2 commented Jun 11, 2025 •
edited
Loading

Description

  1. Update drift annotation for two classes per issue Thrift protocol generation issues for TimeZoneKey and HostAddress #25287

Motivation and Context

Impact

Test Plan

  1. passed verifier tests
  2. Updated idl
Screenshot 2025-06-11 at 14 51 53

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@shangm2 shangm2 requested review from a team and elharo as code owners June 11, 2025 21:53
@shangm2 shangm2 requested a review from hantangwangd June 11, 2025 21:53
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jun 11, 2025
@shangm2 shangm2 merged commit 8e4c0c8 into prestodb:master Jun 12, 2025
100 checks passed
vhsu14 added a commit to vhsu14/presto that referenced this pull request Jun 12, 2025
@vhsu14 @facebook-github-bot
[native] changes in ProtocolToThrift files based on IDL change
1bc0f8d 
Summary:
IDL changes for TimeZoneKey and HostAddress in prestodb#25292 to address prestodb#25287

Rollback Plan:

Differential Revision: D76545874
@vhsu14 vhsu14 mentioned this pull request Jun 12, 2025
Merged
6 tasks
vhsu14 added a commit to vhsu14/presto that referenced this pull request Jun 12, 2025
@vhsu14 @facebook-github-bot
[native] changes in ProtocolToThrift files based on IDL change (prest…
a91172b 
…odb#25308)

Summary:
Pull Request resolved: prestodb#25308

IDL changes for TimeZoneKey and HostAddress in prestodb#25292 to address prestodb#25287

Rollback Plan:

Differential Revision: D76545874
vhsu14 added a commit to vhsu14/presto that referenced this pull request Jun 16, 2025
@vhsu14
[native] changes in ProtocolToThrift files based on IDL change (prest…
30f6642 
…odb#25308)

Summary:
Pull Request resolved: prestodb#25308

IDL changes for TimeZoneKey and HostAddress in prestodb#25292 to address prestodb#25287

Rollback Plan:

Differential Revision: D76545874
vhsu14 added a commit that referenced this pull request Jun 17, 2025
@vhsu14
[native] changes in ProtocolToThrift files based on IDL change (#25308)
60360ce 
## Description
Make relevant changes in cpp based on IDL changes for TimeZoneKey and
HostAddress in #25292 to address
#25287
## Motivation and Context
<!---Why is this change required? What problem does it solve?-->
<!---If it fixes an open issue, please link to the issue here.-->

## Impact
<!---Describe any public API or user-facing feature change or any
performance impact-->

## Test Plan
Verifier (227811)


## Contributor checklist

- [x] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [x] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [x] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [x] Adequate tests were added if applicable.
- [x] CI passed.

## Release Notes

```
== NO RELEASE NOTE ==
```
@vhsu14 vhsu14 mentioned this pull request Jun 18, 2025
Closed
zoltan pushed a commit to zoltan/presto that referenced this pull request Jun 18, 2025
@vhsu14 @zoltan
[native] changes in ProtocolToThrift files based on IDL change (prest…
9936653 
…odb#25308)

## Description
Make relevant changes in cpp based on IDL changes for TimeZoneKey and
HostAddress in prestodb#25292 to address
prestodb#25287
## Motivation and Context
<!---Why is this change required? What problem does it solve?-->
<!---If it fixes an open issue, please link to the issue here.-->

## Impact
<!---Describe any public API or user-facing feature change or any
performance impact-->

## Test Plan
Verifier (227811)


## Contributor checklist

- [x] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [x] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [x] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [x] Adequate tests were added if applicable.
- [x] CI passed.

## Release Notes

```
== NO RELEASE NOTE ==
```
@unidevel unidevel mentioned this pull request Jun 19, 2025
Closed
6 tasks
anandamideShakyan pushed a commit to anandamideShakyan/presto that referenced this pull request Jun 19, 2025
@shangm2 @anandamideShakyan
Update drift annotation for HostAddress and TimeZoneKey (prestodb#25292)
565e957 
## Description
1. Update drift annotation for two classes per issue
prestodb#25287

## Motivation and Context
<!---Why is this change required? What problem does it solve?-->
<!---If it fixes an open issue, please link to the issue here.-->

## Impact
<!---Describe any public API or user-facing feature change or any
performance impact-->

## Test Plan
1. passed verifier tests
2. Updated idl
<img width="259" alt="Screenshot 2025-06-11 at 14 51 53"
src="https://github.com/user-attachments/assets/d90b9335-649d-4a79-b58b-59fedecf5414"
/>


## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.

## Release Notes

```
== NO RELEASE NOTE ==
```
anandamideShakyan pushed a commit to anandamideShakyan/presto that referenced this pull request Jun 19, 2025
@vhsu14 @anandamideShakyan
[native] changes in ProtocolToThrift files based on IDL change (prest…
2f2f55f 
…odb#25308)

## Description
Make relevant changes in cpp based on IDL changes for TimeZoneKey and
HostAddress in prestodb#25292 to address
prestodb#25287
## Motivation and Context
<!---Why is this change required? What problem does it solve?-->
<!---If it fixes an open issue, please link to the issue here.-->

## Impact
<!---Describe any public API or user-facing feature change or any
performance impact-->

## Test Plan
Verifier (227811)


## Contributor checklist

- [x] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [x] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [x] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [x] Adequate tests were added if applicable.
- [x] CI passed.

## Release Notes

```
== NO RELEASE NOTE ==
```
This was referenced Jul 4, 2025
Merged
Closed
Closed
This was referenced Jul 24, 2025
Merged
Merged
@prestodb-ci prestodb-ci mentioned this pull request Jul 28, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikhilCollooru NikhilCollooru NikhilCollooru approved these changes

@elharo elharo Awaiting requested review from elharo elharo is a code owner

@hantangwangd hantangwangd Awaiting requested review from hantangwangd hantangwangd is a code owner automatically assigned from prestodb/committers

Assignees

No one assigned

Labels

from:Meta PR from Meta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shangm2 @NikhilCollooru @prestodb-ci