-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Restore exception handling for IllegalArgumentException during type resolution #24981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@woshizhouyihao This could resolve the internal pipeline failure you are seeing. |
|
@woshizhouyihao Will you be able to try this patch in your clusters? |
|
Hi i m building a binary and deploying it. i will keep you updated |
|
I have verified those failed queries succeeded with the new build. |
amitkdutta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pdabre12
|
@pdabre12 @woshizhouyihao I assume with this chance, we don't need to merge the two reverts |
Description
In #24179, the exception thrown when a parsing an unknown type was replaced from
IllegalArgumentExceptionto a new ExceptionUnknownTypeException. As a result of this, exception handling forIllegalArgumentExceptionwas removed. ButIllegalArgumentExceptioncan be thrown at multiple places down that execution path, so this change adds exception handling forIllegalArgumentExceptionback.Motivation and Context
Solves the issue described in this PR: #24963
Impact
No Impact
Test Plan
Contributor checklist
Release Notes