Skip to content

Conversation

@pdabre12
Copy link
Contributor

@pdabre12 pdabre12 commented Apr 24, 2025

Description

In #24179, the exception thrown when a parsing an unknown type was replaced from IllegalArgumentException to a new Exception UnknownTypeException. As a result of this, exception handling for IllegalArgumentException was removed. But IllegalArgumentException can be thrown at multiple places down that execution path, so this change adds exception handling for IllegalArgumentException back.

Motivation and Context

Solves the issue described in this PR: #24963

Impact

No Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Apr 24, 2025
@pdabre12 pdabre12 marked this pull request as ready for review April 24, 2025 22:28
@pdabre12 pdabre12 requested a review from a team as a code owner April 24, 2025 22:28
@pdabre12 pdabre12 requested a review from jaystarshot April 24, 2025 22:28
@prestodb-ci prestodb-ci requested review from a team, Dilli-Babu-Godari and ShahimSharafudeen and removed request for a team April 24, 2025 22:28
@pdabre12
Copy link
Contributor Author

pdabre12 commented Apr 24, 2025

@woshizhouyihao This could resolve the internal pipeline failure you are seeing.
Unfortunately, do not have enough context on the failing query to add a unit test.

@pdabre12 pdabre12 changed the title Capture IllegalArgumentException while resolving enum literal type Add exception handling for IllegalArgumentException while resolving enum literal type Apr 24, 2025
@pdabre12 pdabre12 changed the title Add exception handling for IllegalArgumentException while resolving enum literal type Add back exception handling for IllegalArgumentException while resolving type Apr 25, 2025
@pdabre12 pdabre12 changed the title Add back exception handling for IllegalArgumentException while resolving type Restore exception handling for IllegalArgumentException during type resolution Apr 25, 2025
@pdabre12
Copy link
Contributor Author

@woshizhouyihao Will you be able to try this patch in your clusters?

@woshizhouyihao
Copy link
Contributor

Hi i m building a binary and deploying it. i will keep you updated

@woshizhouyihao
Copy link
Contributor

I have verified those failed queries succeeded with the new build.
@amitkdutta can you approve this PR. Thanks.

Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pdabre12

@amitkdutta
Copy link
Contributor

@pdabre12 @woshizhouyihao I assume with this chance, we don't need to merge the two reverts
#24963
#24961
Then we can close those 2 PR as well.

@pdabre12 pdabre12 merged commit 86d05e7 into prestodb:master Apr 25, 2025
97 checks passed
@pdabre12 pdabre12 deleted the fix-issue branch April 25, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants