revert TypeManager change to unblock internal pipeline error#24963
Closed
woshizhouyihao wants to merge 1 commit intoprestodb:masterfrom
Closed
revert TypeManager change to unblock internal pipeline error#24963woshizhouyihao wants to merge 1 commit intoprestodb:masterfrom
woshizhouyihao wants to merge 1 commit intoprestodb:masterfrom
Conversation
Contributor
Author
|
We got 2 exceptions from production. Discussion in old PR: #24961 For this first error, given company policy, cannot share original query here. I think it is introduced by the enum values. Example query snippet for the second error below: |
amitkdutta
approved these changes
Apr 24, 2025
Contributor
amitkdutta
left a comment
There was a problem hiding this comment.
Thanks @woshizhouyihao for debugging and finding examples.
NikhilCollooru
approved these changes
Apr 24, 2025
Contributor
|
Folks @pdabre12 is suggesting he is going to come up with a fix asap. May be lets wait for revert? |
6 tasks
Contributor
|
Raised a PR #24981 |
Contributor
Author
|
will merge #24981 for a fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.