Skip to content

Restore exception handling for IllegalArgumentException during type resolution #24981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdabre12 merged 1 commit into from
Apr 25, 2025
Merged

Restore exception handling for IllegalArgumentException during type resolution #24981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-main-base/src/main/java/com/facebook/presto/execution/AddColumnTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public ListenableFuture<?> execute(AddColumn statement, TransactionManager trans
try {
type = metadata.getType(parseTypeSignature(element.getType()));
}
catch (UnknownTypeException e) {
catch (IllegalArgumentException | UnknownTypeException e) {
throw new SemanticException(TYPE_MISMATCH, element, "Unknown type '%s' for column '%s'", element.getType(), element.getName());
}
if (type.equals(UNKNOWN)) {
Expand Down
2 changes: 1 addition & 1 deletion presto-main-base/src/main/java/com/facebook/presto/execution/CreateTableTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public ListenableFuture<?> internalExecute(CreateTable statement, Metadata metad
try {
type = metadata.getType(parseTypeSignature(column.getType()));
}
catch (UnknownTypeException e) {
catch (IllegalArgumentException | UnknownTypeException e) {
throw new SemanticException(TYPE_MISMATCH, element, "Unknown type '%s' for column '%s'", column.getType(), column.getName());
}
if (type.equals(UNKNOWN)) {
Expand Down
4 changes: 2 additions & 2 deletions presto-main-base/src/main/java/com/facebook/presto/sql/analyzer/ExpressionAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,7 @@ protected Type visitGenericLiteral(GenericLiteral node, StackableAstVisitorConte
try {
type = functionAndTypeResolver.getType(parseTypeSignature(node.getType()));
}
catch (UnknownTypeException e) {
catch (IllegalArgumentException | UnknownTypeException e) {
throw new SemanticException(TYPE_MISMATCH, node, "Unknown type: " + node.getType());
}

Expand All @@ -913,7 +913,7 @@ protected Type visitEnumLiteral(EnumLiteral node, StackableAstVisitorContext<Con
try {
type = functionAndTypeResolver.getType(parseTypeSignature(node.getType()));
}
catch (UnknownTypeException e) {
catch (IllegalArgumentException | UnknownTypeException e) {
throw new SemanticException(TYPE_MISMATCH, node, "Unknown type: " + node.getType());
}

Expand Down
2 changes: 1 addition & 1 deletion presto-main-base/src/main/java/com/facebook/presto/sql/analyzer/ExpressionTreeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ public static Optional<TypeWithName> tryResolveEnumLiteralType(QualifiedName qua
return Optional.of((TypeWithName) baseType);
}
}
catch (UnknownTypeException e) {
catch (IllegalArgumentException | UnknownTypeException e) {
return Optional.empty();
}
return Optional.empty();
Expand Down
Loading