OperatorStats overflow fix#24843
Merged
natashasehgal merged 1 commit intoprestodb:masterfrom Apr 2, 2025
Merged
Conversation
kewang1024
approved these changes
Apr 1, 2025
rschlussel
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In OperatorStats, summing long types leads to overflow. Use double type to do calculation.
If final result is larger than Long.MAX_VALUE, return Long.MAX_VALUE.
Motivation and Context
This fix was originally made in March 2024 and accidentally reverted on March 2025
Fix: #22230
Revert of fix:
#24414
#24750
Impact
Test Plan
Contributor checklist
Release Notes