Fix long overflow for OperatorStats#22230
Merged
kewang1024 merged 1 commit intoprestodb:masterfrom Mar 20, 2024
Merged
Conversation
kewang1024
force-pushed
the
Fix-Operator-Stats
branch
from
56307df to
ac86c21
Compare
tdcmeehan
requested changes
Mar 18, 2024
Contributor
tdcmeehan
left a comment
tdcmeehan
left a comment
There was a problem hiding this comment.
Can you add a test case for this in TestOperatorStats?
| joinProbeKeyCount); | ||
| } | ||
|
|
||
| public static long convertDoubleToLong(double dataSize) |
Contributor
There was a problem hiding this comment.
I think we could remove this and just use a simple cast. See https://docs.oracle.com/javase/specs/jls/se8/html/jls-5.html#jls-5.1.3
kewang1024
force-pushed
the
Fix-Operator-Stats
branch
from
ac86c21 to
990ace2
Compare
Collaborator
Author
|
Thanks @tdcmeehan for your good suggestions, just updated accordingly |
kewang1024
force-pushed
the
Fix-Operator-Stats
branch
2 times, most recently
from
d5bf970 to
4a5e381
Compare
Summing long types leads to overflow and query failure, use double to do calculation. If final result is larger than Long.MAX_VALUE, return Long.MAX_VALUE.
kewang1024
force-pushed
the
Fix-Operator-Stats
branch
from
4a5e381 to
adc9d70
Compare
tdcmeehan
approved these changes
Mar 20, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In OperatorStats, summing long types leads to overflow. Use double type to do calculation.
If final result is larger than Long.MAX_VALUE, return Long.MAX_VALUE.