Skip to content

Revert "Improve the merging of operator stats"#24750

Merged
shangm2 merged 1 commit intoprestodb:masterfrom
shangm2:revert
Mar 19, 2025
Merged

Revert "Improve the merging of operator stats"#24750
shangm2 merged 1 commit intoprestodb:masterfrom
shangm2:revert

Conversation

@shangm2
Copy link
Contributor

@shangm2 shangm2 commented Mar 18, 2025

This reverts commit 510024d.

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@shangm2 shangm2 requested a review from a team as a code owner March 18, 2025 23:48
@shangm2 shangm2 requested a review from jaystarshot March 18, 2025 23:48
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Mar 18, 2025
@facebook-github-bot
Copy link
Collaborator

@shangm2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@amitkdutta
Copy link
Contributor

@shangm2 Thanks for the revert. Do we need to revert any related PRs (especially for naive engine) that was dependent on this?

@shangm2
Copy link
Contributor Author

shangm2 commented Mar 19, 2025

@shangm2 Thanks for the revert. Do we need to revert any related PRs (especially for naive engine) that was dependent on this?

We should be good.

@pgupta2 pgupta2 requested review from pgupta2 and removed request for pgupta2 March 19, 2025 01:58
@shangm2 shangm2 merged commit 7dc32b4 into prestodb:master Mar 19, 2025
94 checks passed
shangm2 added a commit that referenced this pull request Mar 19, 2025
@jaystarshot
Copy link
Member

Can you please add more details on why the revert was needed?

@amitkdutta
Copy link
Contributor

Can you please add more details on why the revert was needed?

Upon presto query completion, writtenpartitions is logged to other data lineage services at Meta. We observed that this PR makes writtenpartitions always empty, which breaks the contract. @shangm2 and @pgupta2 can provide further details, and we should update the PR description with more details.

@prestodb-ci prestodb-ci mentioned this pull request Mar 28, 2025
30 tasks
@natashasehgal natashasehgal mentioned this pull request Apr 1, 2025
7 tasks
pradeepvaka pushed a commit to pradeepvaka/presto that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants