Skip to content

Turn on optimized_scale_writer_producer_buffer by default #23774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaystarshot merged 1 commit into from
Oct 7, 2024
Merged

Turn on optimized_scale_writer_producer_buffer by default #23774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public class FeaturesConfig
private boolean redistributeWrites = true;
private boolean scaleWriters;
private DataSize writerMinSize = new DataSize(32, MEGABYTE);
private boolean optimizedScaleWriterProducerBuffer;
private boolean optimizedScaleWriterProducerBuffer = true;
private boolean optimizeMetadataQueries;
private boolean optimizeMetadataQueriesIgnoreStats;
private int optimizeMetadataQueriesCallThreshold = 100;
Expand Down
6 changes: 3 additions & 3 deletions presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public void testDefaults()
.setRedistributeWrites(true)
.setScaleWriters(false)
.setWriterMinSize(new DataSize(32, MEGABYTE))
.setOptimizedScaleWriterProducerBuffer(false)
.setOptimizedScaleWriterProducerBuffer(true)
.setOptimizeMetadataQueries(false)
.setOptimizeMetadataQueriesIgnoreStats(false)
.setOptimizeMetadataQueriesCallThreshold(100)
Expand Down Expand Up @@ -306,7 +306,7 @@ public void testExplicitPropertyMappings()
.put("redistribute-writes", "false")
.put("scale-writers", "true")
.put("writer-min-size", "42GB")
.put("optimized-scale-writer-producer-buffer", "true")
.put("optimized-scale-writer-producer-buffer", "false")
.put("optimizer.optimize-metadata-queries", "true")
.put("optimizer.optimize-metadata-queries-ignore-stats", "true")
.put("optimizer.optimize-metadata-queries-call-threshold", "200")
Expand Down Expand Up @@ -506,7 +506,7 @@ public void testExplicitPropertyMappings()
.setRedistributeWrites(false)
.setScaleWriters(true)
.setWriterMinSize(new DataSize(42, GIGABYTE))
.setOptimizedScaleWriterProducerBuffer(true)
.setOptimizedScaleWriterProducerBuffer(false)
.setOptimizeMetadataQueries(true)
.setOptimizeMetadataQueriesIgnoreStats(true)
.setOptimizeMetadataQueriesCallThreshold(200)
Expand Down