[native] Add session property for bucket write#23741
Closed
kewang1024 wants to merge 1 commit intoprestodb:masterfrom
Closed
[native] Add session property for bucket write#23741kewang1024 wants to merge 1 commit intoprestodb:masterfrom
kewang1024 wants to merge 1 commit intoprestodb:masterfrom
Conversation
xiaoxmeng
approved these changes
Sep 27, 2024
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@kewang1024 thanks for adding this!
| kNativeTaskBucketedWriterCount, | ||
| "Number of writers per task for bucketed writes.", | ||
| INTEGER(), | ||
| false, |
Contributor
There was a problem hiding this comment.
What does false mean here? Thanks!
Collaborator
Author
There was a problem hiding this comment.
Whether it's hidden or not
NikhilCollooru
approved these changes
Sep 27, 2024
xiaoxmeng
reviewed
Sep 28, 2024
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@kewang1024 can we remove the power of 2 limitation for task_partitioned_writer_count so we can just use it to configure in Prestissimo.
Contributor
|
Consider adding documentation for this session property to https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/features.rst#session-properties |
Contributor
|
@kewang1024 we don't need this PR and close it for now. Thanks! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.