Skip to content

[native] Add session property for bucket write #23741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kewang1024 wants to merge 1 commit into from
Closed

[native] Add session property for bucket write #23741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ public final class SystemSessionProperties

public static final String NATIVE_MAX_PARTIAL_AGGREGATION_MEMORY = "native_max_partial_aggregation_memory";
public static final String NATIVE_MAX_EXTENDED_PARTIAL_AGGREGATION_MEMORY = "native_max_extended_partial_aggregation_memory";
public static final String NATIVE_TASK_BUCKETED_WRITER_COUNT = "native_task_bucketed_writer_count";
public static final String NATIVE_MAX_SPILL_BYTES = "native_max_spill_bytes";
public static final String DEFAULT_VIEW_SECURITY_MODE = "default_view_security_mode";
public static final String JOIN_PREFILTER_BUILD_SIDE = "join_prefilter_build_side";
Expand Down Expand Up @@ -1768,6 +1769,11 @@ public SystemSessionProperties(
"The max partial aggregation memory when data reduction is optimal.",
1L << 26,
false),
integerProperty(
NATIVE_TASK_BUCKETED_WRITER_COUNT,
"Number of writers per task for bucketed writes.",
7,
false),
longProperty(
NATIVE_MAX_SPILL_BYTES,
"The max allowed spill bytes",
Expand Down
8 changes: 8 additions & 0 deletions presto-native-execution/presto_cpp/main/SessionProperties.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,14 @@ SessionProperties::SessionProperties() {
QueryConfig::kDebugDisableExpressionWithLazyInputs,
boolToString(c.debugDisableExpressionsWithLazyInputs()));

addSessionProperty(
kNativeTaskBucketedWriterCount,
"Number of writers per task for bucketed writes.",
INTEGER(),
false,
Copy link
Copy Markdown
Contributor

@xiaoxmeng xiaoxmeng Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does false mean here? Thanks!

Copy link
Copy Markdown
Collaborator Author

@kewang1024 kewang1024 Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether it's hidden or not

QueryConfig::kTaskBucketedWriterCount,
std::to_string(c.taskBucketedWriterCount()));

addSessionProperty(
kSelectiveNimbleReaderEnabled,
"Temporary flag to control whether selective Nimble reader should be "
Expand Down
3 changes: 3 additions & 0 deletions presto-native-execution/presto_cpp/main/SessionProperties.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ class SessionProperties {
static constexpr const char* kSelectiveNimbleReaderEnabled =
"native_selective_nimble_reader_enabled";

static constexpr const char* kNativeTaskBucketedWriterCount =
"native_task_bucketed_writer_count";

/// Enable timezone-less timestamp conversions.
static constexpr const char* kLegacyTimestamp = "legacy_timestamp";

Expand Down