Remove logback core depenency as it's not been used anywhere#21819
Remove logback core depenency as it's not been used anywhere#21819ajaygeorge merged 1 commit intoprestodb:masterfrom
Conversation
|
Similar to my suggestion on PR 21668, if removing this package is appropriate, then - as this is a change to the Presto code - perhaps something other than Perhaps something like the following: Note: If |
skairali
left a comment
There was a problem hiding this comment.
This is a good change from security perspective. We don't need to keep and maintain unused packages
|
@Akanksha-kedia can you please add the release notes changes as @steveburnett suggested |
|
@steveburnett please review |
|
@tdcmeehan please help to review |
|
Could you share the result of the test cases you ran in your Test Plan? |
|
@tdcmeehan please help to review @skairali help to merge. @steveburnett |
|
Couple of small nits
|
|
@ajaygeorge i have done. |


Description
Remove logback core depenency as its not been used anywhere
Motivation and Context
i see vulnerabilities as well:
Direct vulnerabilities:
CVE-2023-6378
CVE-2021-42550
using mvn dependency:tree -Dmaven.wagon.http.ssl.insecure=true -Dmaven.wagon.http.ssl.allowall=true
+- com.facebook.airlift:log:jar:0.207:compile
[INFO] +- com.facebook.airlift:log-manager:jar:0.207:compile
[INFO] | +- org.slf4j:slf4j-jdk14:jar:1.7.25:runtime
[INFO] | | - org.slf4j:slf4j-api:jar:1.7.25:runtime
[INFO] | +- org.slf4j:log4j-over-slf4j:jar:1.7.25:runtime
[INFO] | +- org.slf4j:jcl-over-slf4j:jar:1.7.25:runtime
[INFO] | - ch.qos.logback:logback-core:jar:1.2.3:compile
[INFO] +- com.facebook.airlift:http-server:jar:0.207:compile
[INFO] | +- com.facebook.airlift:http-utils:jar:0.207:compile
[INFO] | +- com.facebook.airlift:security:jar:0.207:compile
[INFO] | +- com.facebook.airlift:stats:jar:0.207:compile
[INFO] | | +- org.hdrhistogram:HdrHistogram:jar:2.1.9:compile
[INFO] | | +- io.airlift:slice:jar:0.34:compile
presto directly is not using the dependency of logback-core
Impact
no impact
Test Plan
Ran test cases
Contributor checklist
Release Notes