Skip to content

Fix UUID distinct operation issue #23732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 1 commit into from
Oct 7, 2024
Merged

Fix UUID distinct operation issue #23732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-main/src/main/java/com/facebook/presto/type/UuidOperators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public static boolean isDistinctFrom(
if (left.isNull(leftPosition)) {
return false;
}
return left.compareTo(leftPosition, 0, UUID.getFixedSize(), right, rightPosition, 0, UUID.getFixedSize()) != 0;
return !UUID.equalTo(left, leftPosition, right, rightPosition);
}
}

Expand Down
10 changes: 10 additions & 0 deletions presto-main/src/test/java/com/facebook/presto/sql/query/TestDistinctAggregations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,4 +272,14 @@ public void testMixedDistinctWithFilter()
"FROM (VALUES (1, 3), (2, 4), (2, 4), (4, 5)) t (x, y)",
"VALUES (BIGINT '0', CAST(NULL AS BIGINT))");
}

@Test
public void testUuidDistinct()
Copy link
Copy Markdown
Contributor

@aditi-pandit aditi-pandit Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BryanCutler : We should check how this works in Prestissimo as well. Don't anticipate a problem, but it would be good to make it part of the tests.

{
assertions.assertQuery(
"SELECT DISTINCT uuid_col " +
"FROM (VALUES (UUID'be0b0518-35a1-4d10-b7f1-1b61355fa741')," +
" (UUID'be0b0518-35a1-4d10-b7f1-1b61355fa741')) AS t (uuid_col)",
"VALUES UUID'be0b0518-35a1-4d10-b7f1-1b61355fa741'");
}
}