Skip to content

[native] Make node.id optional#22815

Merged
aditi-pandit merged 2 commits intoprestodb:masterfrom
majetideepak:auto-node-id
May 24, 2024
Merged

[native] Make node.id optional#22815
aditi-pandit merged 2 commits intoprestodb:masterfrom
majetideepak:auto-node-id

Conversation

@majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented May 24, 2024

Description

Make node.id optional in line with the Java implementation.
Auto-generate node.id if missing.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Prestissimo (Native Execution)
* Make node.id optional :pr:`22815`

@majetideepak majetideepak requested a review from a team as a code owner May 24, 2024 02:47
@majetideepak majetideepak changed the title [native] Make nodeid optional [native] Make node.id optional May 24, 2024
@majetideepak
Copy link
Collaborator Author

I verified locally that this works.

@majetideepak
Copy link
Collaborator Author

@amitkdutta can you help review this? Thanks.

Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @majetideepak. Had a minor comment.

amitkdutta
amitkdutta previously approved these changes May 24, 2024
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end.

Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @majetideepak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants