[native] Make node.id optional#22815
Merged
aditi-pandit merged 2 commits intoprestodb:masterfrom May 24, 2024
Merged
Conversation
fe1fcaa to
1bcaf93
Compare
Collaborator
Author
|
I verified locally that this works. |
Collaborator
Author
|
@amitkdutta can you help review this? Thanks. |
Contributor
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks @majetideepak. Had a minor comment.
amitkdutta
previously approved these changes
May 24, 2024
Contributor
amitkdutta
left a comment
There was a problem hiding this comment.
Looks good from my end.
1bcaf93 to
35320f0
Compare
aditi-pandit
approved these changes
May 24, 2024
Contributor
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks @majetideepak
6 tasks
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make node.id optional in line with the Java implementation.
Auto-generate node.id if missing.
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.