Skip to content

[native] Move optional node config test in existing ConfigTest.#22826

Merged
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:config_test_fix
May 24, 2024
Merged

[native] Move optional node config test in existing ConfigTest.#22826
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:config_test_fix

Conversation

@amitkdutta
Copy link
Contributor

Description

We added optional node id test in #22815 in a new test file. However, there is already a configtest file, so moving the test there and deleting the new one.

Motivation and Context

Merge duplicated test files.

Impact

None

Test Plan

Unit tests

== NO RELEASE NOTE ==

@amitkdutta amitkdutta requested a review from a team as a code owner May 24, 2024 17:49
Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @amitkdutta! I missed this file.

@amitkdutta amitkdutta merged commit 98e941f into prestodb:master May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants