Skip to content

[native] add entrypoint script into native worker docker image#23030

Merged
wanglinsong merged 1 commit intoprestodb:masterfrom
wanglinsong:native-image-entrypoint
Jun 21, 2024
Merged

[native] add entrypoint script into native worker docker image#23030
wanglinsong merged 1 commit intoprestodb:masterfrom
wanglinsong:native-image-entrypoint

Conversation

@wanglinsong
Copy link
Member

Description

Add default docker image entrypoint script

Motivation and Context

Make the image consistent with the Java docker image

Impact

None

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@wanglinsong wanglinsong requested a review from a team as a code owner June 19, 2024 07:00
@wanglinsong wanglinsong force-pushed the native-image-entrypoint branch from 1163bd0 to 10ef99b Compare June 19, 2024 07:00
czentgr
czentgr previously approved these changes Jun 19, 2024
@majetideepak majetideepak requested a review from a team June 19, 2024 17:02
Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wanglinsong can you please squash the commits? Thanks.

@wanglinsong wanglinsong force-pushed the native-image-entrypoint branch from b53f00d to 1af05de Compare June 20, 2024 18:34
@wanglinsong wanglinsong requested a review from majetideepak June 20, 2024 18:34
@majetideepak
Copy link
Collaborator

@wanglinsong the singlestore tests job is failing and I am unable to rerun it. Can you amend and push again?

@wanglinsong
Copy link
Member Author

@wanglinsong the singlestore tests job is failing and I am unable to rerun it. Can you amend and push again?

This suite is disabled in other PRs, due to flakiness. https://prestodb.slack.com/archives/CLYMEEJ6S/p1718930578438049?thread_ts=1718390428.917579&cid=CLYMEEJ6S

@wanglinsong wanglinsong merged commit 210876e into prestodb:master Jun 21, 2024
@wanglinsong wanglinsong deleted the native-image-entrypoint branch June 21, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants