Skip to content

[native] Advance velox.#22812

Closed
amitkdutta wants to merge 1 commit intoprestodb:masterfrom
amitkdutta:new_velox
Closed

[native] Advance velox.#22812
amitkdutta wants to merge 1 commit intoprestodb:masterfrom
amitkdutta:new_velox

Conversation

@amitkdutta
Copy link
Contributor

No description provided.

@amitkdutta amitkdutta requested a review from a team as a code owner May 23, 2024 11:16
@amitkdutta
Copy link
Contributor Author

amitkdutta commented May 23, 2024

Observing CMake version failure in CI

CMake Error at velox/CMakeLists.txt:14 (cmake_minimum_required):
  CMake 3.28 or higher is required.  You are running version 3.26.5

This is due to CMake version is updated in velox facebookincubator/velox#9861

I ran into same problem locally as well. Updated CLion to latest version (CLion 2024.1.1, Build #CL-241.15989.121, built on April 25, 2024) to unblock.

We need to update here as well to unblock builds on latest velox.

CC: @majetideepak @kgpai @mbasmanova @aditi-pandit

@majetideepak
Copy link
Collaborator

@amitkdutta We have to build a new CI Image. The Presto release team should be able to help with this.
CC: @tdcmeehan, @wanglinsong

@wanglinsong
Copy link
Member

@amitkdutta We have to build a new CI Image. The Presto release team should be able to help with this. CC: @tdcmeehan, @wanglinsong

@majetideepak are you talking about the base build image?

@majetideepak
Copy link
Collaborator

majetideepak commented May 27, 2024

@wanglinsong this would be the centos dependency image. We need to build it after advancing Velox. I built it this time here
#22839. Can you please upload it to AWS?

@wanglinsong
Copy link
Member

We need to finish this first #22806, which has an option to build the centos dependency docker image.

@amitkdutta amitkdutta closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants