Skip to content

[native] Update CI image and Advance Velox#22839

Merged
majetideepak merged 2 commits intoprestodb:masterfrom
majetideepak:update-velox
May 28, 2024
Merged

[native] Update CI image and Advance Velox#22839
majetideepak merged 2 commits intoprestodb:masterfrom
majetideepak:update-velox

Conversation

@majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented May 27, 2024

Description

Update CI image to include CMake changes from Velox.
Advance Velox.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

If release note is NOT required, use:

== NO RELEASE NOTE ==

xiaoxmeng
xiaoxmeng previously approved these changes May 27, 2024
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majetideepak thank you!

@majetideepak
Copy link
Collaborator Author

@wanglinsong Can you please upload docker.io/majetideepak4/prestocpp:root-20240527 to the Presto AWS account?
The CI is passing with that image. This image was built using podman compose build centos-native-dependency after advancing Velox.
Thanks!

@majetideepak majetideepak changed the title [native] Update velox [native] Advance velox May 27, 2024
@majetideepak majetideepak changed the title [native] Advance velox [native] Advance Velox May 27, 2024
@majetideepak majetideepak marked this pull request as ready for review May 27, 2024 05:11
@majetideepak majetideepak requested review from a team as code owners May 27, 2024 05:11
@majetideepak majetideepak requested a review from presto-oss May 27, 2024 05:11
@wanglinsong
Copy link
Member

This is published as public.ecr.aws/oss-presto/prestocpp:root-20240527.

@wanglinsong Can you please upload docker.io/majetideepak4/prestocpp:root-20240527 to the Presto AWS account? The CI is passing with that image. This image was built using podman compose build centos-native-dependency after advancing Velox. Thanks!

docker:
# These images are managed by the Presto Release team.
- image: public.ecr.aws/oss-presto/prestocpp:root-20240416
- image: docker.io/majetideepak4/prestocpp:root-20240527
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #22806 is merged, you can use the new dependency image - public.ecr.aws/oss-presto/presto-native-dependency:latest

See: https://us-east-1.console.aws.amazon.com/ecr/repositories/public/932483864676/presto-native-dependency?region=us-east-1

@majetideepak majetideepak changed the title [native] Advance Velox [native] Update CI image and Advance Velox May 27, 2024
@majetideepak
Copy link
Collaborator Author

@amitkdutta, @xiaoxmeng can you approve this PR? Thanks.

@majetideepak majetideepak requested a review from tdcmeehan May 27, 2024 23:51
@majetideepak
Copy link
Collaborator Author

@tdcmeehan can you please approve this PR?

Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@majetideepak majetideepak merged commit 831d594 into prestodb:master May 28, 2024
@majetideepak majetideepak deleted the update-velox branch May 29, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants