Update cmake to version 3.28.3#9861
Update cmake to version 3.28.3#9861tigrux wants to merge 1 commit intofacebookincubator:mainfrom tigrux:setup_cmake_328
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
Hello @kgpai, @majetideepak, @assignUser, @pedroerp, @bdice. |
assignUser
left a comment
assignUser
left a comment
There was a problem hiding this comment.
Could you also add the changes to the env files in this PR and add the new cmake version to setup-ubuntu.sh?
assignUser
left a comment
assignUser
left a comment
There was a problem hiding this comment.
Once the docker CI is green, I'll tag this to be merged.
assignUser
added
the
ready-to-merge
kgpai
left a comment
kgpai
left a comment
There was a problem hiding this comment.
This change means we need to update the prestissimo images too.
cc: @majetideepak
|
@tigrux One final thing, can you also update the dependency documentation to list out we require cmake 3.28 ? |
CMake 3.24 and the 3.28 provide two notable improvements to the FetchContent module - New in version 3.24: OVERRIDE_FIND_PACKAGE - This makes the content available to be available for find_package. - New in version 3.28: EXCLUDE_FROM_ALL - Prevents the targets of the content from being added to the all target. These improvements are going to significantly decrease the complexity of dependencies that are provided via cmake modules.
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
Hi @kgpai @assignUser, we notice the docker image |
|
@rui-mo that docker image is outdated and superseded by |
|
@assignUser Thank you for providing us with the detailed information. We will change to use the updated ones. Thanks! |
|
My CLion IDE has CMake 3.25.2 as the default. I had to create a new toolchain for CMake using homebrew CMake (version 3.29.2) by following the steps here https://stackoverflow.com/questions/58506437/cmake-version-in-clion-not-updating |
I updated CLion to latest version (CLion 2024.1.1, Build #CL-241.15989.121, built on April 25, 2024) to fix the issue locally. PrestoDB builds failing when we want to update Velox prestodb/presto#22812 |
|
Seems like this breaks for Fedora 38 users as well as it ships with CMake 3.27 by default. |
|
Any easy way to get the latest cmake is via |
9 participants
CMake 3.24 and the 3.28 provide two notable improvements to the FetchContent module
These improvements are going to significantly decrease the complexity of dependencies that are provided via cmake modules.