Skip to content

Fix sign shift issue in presto #21884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spershin merged 1 commit into from
Feb 8, 2024
Merged

Fix sign shift issue in presto #21884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/presto_protocol/Base64Util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ static const char* kRle = "RLE";
static const char* kArray = "ARRAY";
static const char* kMap = "MAP";
static const char* kInt128Array = "INT128_ARRAY";
static const __int128_t kInt128Mask = ~(static_cast<__int128_t>(1) << 127);
static const __uint128_t kInt128Mask = ~(static_cast<__uint128_t>(1) << 127);
Copy link
Copy Markdown
Contributor

@spershin spershin Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that velox/type/DecimalUtil.h
has
static constexpr uint128_t kInt128Mask = (static_cast<uint128_t>(1) << 127);
And it is not really used anywhere.
I think presto_cpp should maybe use that Velox's constant.
But let's merge this one for now to move fast.


struct ByteStream {
explicit ByteStream(const char* data, int32_t offset = 0)
Expand Down