Skip to content

Pass cat token for view definer mode #21685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jainxrohit merged 1 commit into from
Jan 12, 2024
Merged

Pass cat token for view definer mode #21685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-main/src/main/java/com/facebook/presto/sql/MaterializedViewUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public static Session buildOwnerSession(Session session, Optional<String> owner,
public static Identity getOwnerIdentity(Optional<String> owner, Session session)
{
if (owner.isPresent() && !owner.get().equals(session.getIdentity().getUser())) {
return new Identity(owner.get(), Optional.empty());
return new Identity(owner.get(), Optional.empty(), session.getIdentity().getExtraCredentials());
}
return session.getIdentity();
}
Expand Down
2 changes: 1 addition & 1 deletion presto-main/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2803,7 +2803,7 @@ private RelationType analyzeView(Query query, QualifiedObjectName name, Optional
Identity identity;
AccessControl viewAccessControl;
if (owner.isPresent() && !owner.get().equals(session.getIdentity().getUser())) {
identity = new Identity(owner.get(), Optional.empty());
identity = new Identity(owner.get(), Optional.empty(), session.getIdentity().getExtraCredentials());
viewAccessControl = new ViewAccessControl(accessControl);
}
else {
Expand Down
5 changes: 5 additions & 0 deletions presto-spi/src/main/java/com/facebook/presto/spi/security/Identity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ public Identity(String user, Optional<Principal> principal)
this(user, principal, emptyMap(), emptyMap(), emptyMap(), Optional.empty(), Optional.empty());
}

public Identity(String user, Optional<Principal> principal, Map<String, String> extraCredentials)
{
this(user, principal, emptyMap(), extraCredentials, emptyMap(), Optional.empty(), Optional.empty());
}

public Identity(
String user,
Optional<Principal> principal,
Expand Down