Closed
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Contributor
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
reviewed
Apr 14, 2023
velox/exec/Driver.cpp
Outdated
| std::shared_ptr<BlockingState>& blockingState, | ||
| RowVectorPtr& result) { | ||
| auto queuedTime = (getCurrentTimeMicro() - queueTimeStartMicros_) * 1'000; | ||
| auto now = getCurrentTimeMicro(); |
Contributor
There was a problem hiding this comment.
nit:
const auto now
const auto queuedTime
const auto stop
velox/exec/Task.cpp
Outdated
|
|
||
| int32_t Task::yieldIfDue(uint64_t startTimeMicros) { | ||
| if (onThreadSince_ < startTimeMicros) { | ||
| std::lock_guard<std::mutex> xx(mutex_); |
Adds a function to get a Task off thread after a minimum slice of running time.
xiaoxmeng
approved these changes
Apr 14, 2023
Contributor
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
usurai
pushed a commit
to usurai/velox
that referenced
this pull request
Apr 18, 2023
Summary: Adds a function to get a Task off thread after a minimum slice of running time. Pull Request resolved: facebookincubator#4620 Reviewed By: xiaoxmeng Differential Revision: D45007832 Pulled By: oerling fbshipit-source-id: 0c36274ccce83e05c35dd2606999edeb6cbbcdf1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a function to get a Task off thread after a minimum slice of running time.