Add Shrinidhi as codeowner for presto-spark* modules#20331
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Jul 24, 2023
Merged
Add Shrinidhi as codeowner for presto-spark* modules#20331rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
rschlussel
requested review from
aditi-pandit,
beinan,
highker,
majetideepak,
presto-oss,
tdcmeehan,
xiaoxmeng,
yingsu00 and
zhenxiao
xiaoxmeng
approved these changes
Jul 18, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@rschlussel LGTM. Thanks!
tdcmeehan
approved these changes
Jul 18, 2023
highker
approved these changes
Jul 18, 2023
zhenxiao
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to nominate @shrinidhijoshi to be a code owner for the presto-spark* packages. Shrinidhi has deep understanding of both Java presto-on-spark and presto on spark native. In his contributions and reviews he pays attention to correctness and performance as well as the simplicity/clarity of the code and whether it is aligned with the rest of Presto. Additionally, Shrinidhi thinks holistically about the system architecture, and considerably simplified the original native presto-on-spark implementation by moving the native process creation to the task level.
Some example contributions
full list here: https://github.com/prestodb/presto/pulls?q=is%3Apr+author%3Ashrinidhijoshi
Simplifying how we create the native process for presto-spark + native:
#19799
Spill Support for TopNRowNumberOperator:
#18400
Support for spark local mode:
#19407
#19435
#19629
bug fixes:
#20265
#20295
Some example reviews
full list here: https://github.com/prestodb/presto/pulls?q=is%3Apr+reviewed-by%3Ashrinidhijoshi+-author%3Ashrinidhijoshi+
#19917 (review)
#19676
#19189
#19926
Test plan - CI