[Presto-on-spark native] [localMode] Close executor service on shutdown#19629
Merged
shrinidhijoshi merged 1 commit intomasterfrom May 12, 2023
Merged
[Presto-on-spark native] [localMode] Close executor service on shutdown#19629shrinidhijoshi merged 1 commit intomasterfrom
shrinidhijoshi merged 1 commit intomasterfrom
Conversation
shrinidhijoshi
force-pushed
the
localModeHangs
branch
from
d51e729 to
5dca27a
Compare
mbasmanova
approved these changes
May 12, 2023
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
@shrinidhijoshi Thanks.
presto-spark-base/src/main/java/com/facebook/presto/spark/execution/NativeExecutionProcess.java
Outdated
Show resolved
Hide resolved
presto-spark-base/src/main/java/com/facebook/presto/spark/execution/NativeExecutionProcess.java
Outdated
Show resolved
Hide resolved
shrinidhijoshi
force-pushed
the
localModeHangs
branch
2 times, most recently
from
efabff5 to
34642fa
Compare
tanjialiang
reviewed
May 12, 2023
presto-spark-launcher/src/main/java/com/facebook/presto/spark/launcher/PrestoSparkRunner.java
Outdated
Show resolved
Hide resolved
If we are in localMode, the executor spawns the Executor Airlift application (which is long running and holds onto resources) on the same JVM On query completion, the SparkContext shutdown calls the Driver Airlift application shutdown, but it has no hook to call Executor Airlift application shutdown. So we hang forever. This code, prevents this hanging state by explicity calling the Executor Airlift application to shutdown
shrinidhijoshi
force-pushed
the
localModeHangs
branch
from
34642fa to
0c4fbb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are in localMode, the executor spawns the Executor Airlift application
(which is long running and holds onto resources) on the same JVM
On query completion, the SparkContext shutdown calls the Driver Airlift
application shutdown, but it has no hook to call Executor Airlift application
shutdown. So we hang forever.
This code, prevents this hanging state by explicity calling the
Executor Airlift application to shutdown