[Presto-on-Spark] Move DetachedNativeExecutionProcess from test to src#19435
[Presto-on-Spark] Move DetachedNativeExecutionProcess from test to src#19435shrinidhijoshi merged 1 commit intoprestodb:masterfrom
Conversation
c672f28 to
731d22e
Compare
There was a problem hiding this comment.
There was a problem hiding this comment.
Good catch @miaoever . Looks like there are a few things we can clean up as a part of this. Will update
There was a problem hiding this comment.
Not sure what line it is as that class is no longer there. But things have changed recently so we should double check. Thanks
731d22e to
3954e06
Compare
3954e06 to
7c76e2a
Compare
|
High level question: What is the setup for local mode and why do we need a detached process for local mode? Thanks! |
|
@tanjialiang There 2 types of localMode
|
miaoever
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for adding this @shrinidhijoshi
7c76e2a to
aa4de01
Compare
|
Resolved merge conflicts |
Currently DetachedNativeExecutionProcess class is defined in test folder as it was only being used for test execution. But now that we want to support Presto-on-Spark in localMode, we want to be able to talk to an already running CPP process during e2e query execution. Moving it out into src to enable this
aa4de01 to
c4a4fa3
Compare
|
Test failures are unrelated. I re-ran the tests on laptop and they pass |
mbasmanova
left a comment
There was a problem hiding this comment.
@shrinidhijoshi Please, make sure all CI is green.
|
@mbasmanova Will do. Kicked off the failing tests again |
Currently DetachedNativeExecutionProcess class is defined in test folder as it was only being used for test execution. But now that we want to support Presto-on-Spark in localMode, we want to be able to talk to an already running CPP process during e2e query execution. Moving it out into src to enable this
Test plan (N/A)