Skip to content

Fix QueryError.retriable serialization#21588

Closed
ethanyzhang wants to merge 1 commit intomasterfrom
queryerror-retriable-serial
Closed

Fix QueryError.retriable serialization#21588
ethanyzhang wants to merge 1 commit intomasterfrom
queryerror-retriable-serial

Conversation

@ethanyzhang
Copy link
Copy Markdown
Contributor

Description

Fixed a mistake in QueryError.retriable serialization when sending client response. The field name was previously "boolean" instead of "retriable".

Motivation and Context

Impact

Applications that make use of this field may need to be updated.

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@ethanyzhang ethanyzhang requested a review from a team as a code owner December 21, 2023 09:32
@tdcmeehan
Copy link
Copy Markdown
Contributor

Let's close this in favor of #19741 (which also has a unit test).

@tdcmeehan tdcmeehan closed this Dec 21, 2023
@ethanyzhang ethanyzhang deleted the queryerror-retriable-serial branch July 8, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants