[Native] Enable Tpcds Test for Parquet File by frankobe · Pull Request #19646 · prestodb/presto

frankobe · 2023-05-13T01:11:17Z

Test plan:

This PR adds test for 99 TPC-DS queries on unmodified schemas & SQLs under presto-native-execution.

The test is based on parquet file so unmodified schema from TPC-DS connector is used.

== RELEASE NOTES ==

Native Changes
* Add TPC-DS tests for native execution based on Parquet files

...-native-execution/src/test/java/com/facebook/presto/nativeworker/NativeQueryRunnerUtils.java

...execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeTpcdsQueries.java

Signed-off-by: frankobe <mua08p@gmail.com>

aditi-pandit

Thanks Frank for these tests ! Appreciate it.

mshang816 · 2023-06-22T00:25:32Z

Hi @frankobe
The test class TestPrestoNativeTpcdsQueriesParquetUsingThrift added in the PR is failing on both circle ci and our internal runs. We need to remove or disable the tests before we can fix the failures to avoid noisy ci signals.
c.c. @amitkdutta @majetideepak

frankobe · 2023-06-22T00:49:54Z

Hi @frankobe The test class TestPrestoNativeTpcdsQueriesParquetUsingThrift added in the PR is failing on both circle ci and our internal runs. We need to remove or disable the tests before we can fix the failures to avoid noisy ci signals. c.c. @amitkdutta @majetideepak

Hi @mshang816,

I can definitely take a look. Is there an output log from the CI? I checked a few commits, e.g. https://app.circleci.com/pipelines/github/prestodb/presto/4010/workflows/6cb4c54e-99f0-4bcb-baf7-0dde9f045998/jobs/7744/parallel-runs/3?filterBy=FAILED

I see the failures are on every e2e test case, not limited to TestPrestoNativeTpcdsQueriesParquetUsingThrift

frankobe · 2023-06-22T01:18:48Z

Hi @frankobe The test class TestPrestoNativeTpcdsQueriesParquetUsingThrift added in the PR is failing on both circle ci and our internal runs. We need to remove or disable the tests before we can fix the failures to avoid noisy ci signals. c.c. @amitkdutta @majetideepak

Hi @mshang816,

I can definitely take a look. Is there an output log from the CI? I checked a few commits, e.g. https://app.circleci.com/pipelines/github/prestodb/presto/4010/workflows/6cb4c54e-99f0-4bcb-baf7-0dde9f045998/jobs/7744/parallel-runs/3?filterBy=FAILED

I see the failures are on every e2e test case, not limited to TestPrestoNativeTpcdsQueriesParquetUsingThrift

I checked a few merged commits in master branch, TestPrestoNativeTpcdsQueruesParquetUsingThrift fails due to No worker nodes available

Caused by: java.lang.RuntimeException: No worker nodes available
	at com.facebook.presto.tests.AbstractTestingPrestoClient.execute(AbstractTestingPrestoClient.java:124)
	at com.facebook.presto.tests.DistributedQueryRunner.execute(DistributedQueryRunner.java:726)
	at com.facebook.presto.tests.DistributedQueryRunner.execute(DistributedQueryRunner.java:694)
	at com.facebook.presto.tests.QueryAssertions.assertQuery(QueryAssertions.java:175)
	... 18 more
Caused by: com.facebook.presto.spi.PrestoException: No worker nodes available
	at com.facebook.presto.util.Failures.checkCondition(Failures.java:85)
	at com.facebook.presto.sql.planner.SystemPartitioningHandle.getNodePartitionMap(SystemPartitioningHandle.java:156)
	at com.facebook.presto.sql.planner.NodePartitioningManager.getNodePartitioningMap(NodePartitioningManager.java:122)
	at com.facebook.presto.execution.scheduler.SectionExecutionFactory.lambda$null$0(SectionExecutionFactory.java:171)
	at java.util.HashMap.computeIfAbsent(HashMap.java:1128)

It seems to be related to the test setup, not the test itself. It impacts Q1 & Q10 as they are the first 2 to run

mshang816 · 2023-06-22T02:44:01Z

Hi @frankobe The test class TestPrestoNativeTpcdsQueriesParquetUsingThrift added in the PR is failing on both circle ci and our internal runs. We need to remove or disable the tests before we can fix the failures to avoid noisy ci signals. c.c. @amitkdutta @majetideepak

Hi @mshang816,
I can definitely take a look. Is there an output log from the CI? I checked a few commits, e.g. https://app.circleci.com/pipelines/github/prestodb/presto/4010/workflows/6cb4c54e-99f0-4bcb-baf7-0dde9f045998/jobs/7744/parallel-runs/3?filterBy=FAILED
I see the failures are on every e2e test case, not limited to TestPrestoNativeTpcdsQueriesParquetUsingThrift

I checked a few merged commits in master branch, TestPrestoNativeTpcdsQueruesParquetUsingThrift fails due to No worker nodes available
Caused by: java.lang.RuntimeException: No worker nodes available
	at com.facebook.presto.tests.AbstractTestingPrestoClient.execute(AbstractTestingPrestoClient.java:124)
	at com.facebook.presto.tests.DistributedQueryRunner.execute(DistributedQueryRunner.java:726)
	at com.facebook.presto.tests.DistributedQueryRunner.execute(DistributedQueryRunner.java:694)
	at com.facebook.presto.tests.QueryAssertions.assertQuery(QueryAssertions.java:175)
	... 18 more
Caused by: com.facebook.presto.spi.PrestoException: No worker nodes available
	at com.facebook.presto.util.Failures.checkCondition(Failures.java:85)
	at com.facebook.presto.sql.planner.SystemPartitioningHandle.getNodePartitionMap(SystemPartitioningHandle.java:156)
	at com.facebook.presto.sql.planner.NodePartitioningManager.getNodePartitioningMap(NodePartitioningManager.java:122)
	at com.facebook.presto.execution.scheduler.SectionExecutionFactory.lambda$null$0(SectionExecutionFactory.java:171)
	at java.util.HashMap.computeIfAbsent(HashMap.java:1128)
It seems to be related to the test setup, not the test itself. It impacts Q1 & Q10 as they are the first 2 to run

Here are the two stacktrace from our internal runs:
at org.testng.Assert.fail(Assert.java:110)
at com.facebook.presto.tests.QueryAssertions.assertQueryFails(QueryAssertions.java:329)
at com.facebook.presto.tests.AbstractTestQueryFramework.assertQueryFails(AbstractTestQueryFramework.java:265)
at com.facebook.presto.nativeworker.AbstractTestNativeTpcdsQueries.testTpcdsQ2(AbstractTestNativeTpcdsQueries.java:437)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:135)
at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:673)
at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:220)
at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:50)
at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:945)
at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:193)
at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:128)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)

at org.testng.Assert.fail(Assert.java:110)
at com.facebook.presto.tests.QueryAssertions.assertQueryFails(QueryAssertions.java:329)
at com.facebook.presto.tests.AbstractTestQueryFramework.assertQueryFails(AbstractTestQueryFramework.java:265)
at com.facebook.presto.nativeworker.AbstractTestNativeTpcdsQueries.testTpcdsQ78(AbstractTestNativeTpcdsQueries.java:1012)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:135)
at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:673)
at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:220)
at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:50)
at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:945)
at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:193)
at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:128)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)

mshang816 · 2023-06-22T02:47:40Z

Hi @frankobe The test class TestPrestoNativeTpcdsQueriesParquetUsingThrift added in the PR is failing on both circle ci and our internal runs. We need to remove or disable the tests before we can fix the failures to avoid noisy ci signals. c.c. @amitkdutta @majetideepak

Hi @mshang816,
I can definitely take a look. Is there an output log from the CI? I checked a few commits, e.g. https://app.circleci.com/pipelines/github/prestodb/presto/4010/workflows/6cb4c54e-99f0-4bcb-baf7-0dde9f045998/jobs/7744/parallel-runs/3?filterBy=FAILED
I see the failures are on every e2e test case, not limited to TestPrestoNativeTpcdsQueriesParquetUsingThrift

I checked a few merged commits in master branch, TestPrestoNativeTpcdsQueruesParquetUsingThrift fails due to No worker nodes available
Caused by: java.lang.RuntimeException: No worker nodes available
	at com.facebook.presto.tests.AbstractTestingPrestoClient.execute(AbstractTestingPrestoClient.java:124)
	at com.facebook.presto.tests.DistributedQueryRunner.execute(DistributedQueryRunner.java:726)
	at com.facebook.presto.tests.DistributedQueryRunner.execute(DistributedQueryRunner.java:694)
	at com.facebook.presto.tests.QueryAssertions.assertQuery(QueryAssertions.java:175)
	... 18 more
Caused by: com.facebook.presto.spi.PrestoException: No worker nodes available
	at com.facebook.presto.util.Failures.checkCondition(Failures.java:85)
	at com.facebook.presto.sql.planner.SystemPartitioningHandle.getNodePartitionMap(SystemPartitioningHandle.java:156)
	at com.facebook.presto.sql.planner.NodePartitioningManager.getNodePartitioningMap(NodePartitioningManager.java:122)
	at com.facebook.presto.execution.scheduler.SectionExecutionFactory.lambda$null$0(SectionExecutionFactory.java:171)
	at java.util.HashMap.computeIfAbsent(HashMap.java:1128)
It seems to be related to the test setup, not the test itself. It impacts Q1 & Q10 as they are the first 2 to run

it looks like the native workers crashed.

frankobe · 2023-06-22T03:15:04Z

Hi @frankobe The test class TestPrestoNativeTpcdsQueriesParquetUsingThrift added in the PR is failing on both circle ci and our internal runs. We need to remove or disable the tests before we can fix the failures to avoid noisy ci signals. c.c. @amitkdutta @majetideepak

Hi @mshang816,
I can definitely take a look. Is there an output log from the CI? I checked a few commits, e.g. https://app.circleci.com/pipelines/github/prestodb/presto/4010/workflows/6cb4c54e-99f0-4bcb-baf7-0dde9f045998/jobs/7744/parallel-runs/3?filterBy=FAILED
I see the failures are on every e2e test case, not limited to TestPrestoNativeTpcdsQueriesParquetUsingThrift

I checked a few merged commits in master branch, TestPrestoNativeTpcdsQueruesParquetUsingThrift fails due to No worker nodes available
Caused by: java.lang.RuntimeException: No worker nodes available
	at com.facebook.presto.tests.AbstractTestingPrestoClient.execute(AbstractTestingPrestoClient.java:124)
	at com.facebook.presto.tests.DistributedQueryRunner.execute(DistributedQueryRunner.java:726)
	at com.facebook.presto.tests.DistributedQueryRunner.execute(DistributedQueryRunner.java:694)
	at com.facebook.presto.tests.QueryAssertions.assertQuery(QueryAssertions.java:175)
	... 18 more
Caused by: com.facebook.presto.spi.PrestoException: No worker nodes available
	at com.facebook.presto.util.Failures.checkCondition(Failures.java:85)
	at com.facebook.presto.sql.planner.SystemPartitioningHandle.getNodePartitionMap(SystemPartitioningHandle.java:156)
	at com.facebook.presto.sql.planner.NodePartitioningManager.getNodePartitioningMap(NodePartitioningManager.java:122)
	at com.facebook.presto.execution.scheduler.SectionExecutionFactory.lambda$null$0(SectionExecutionFactory.java:171)
	at java.util.HashMap.computeIfAbsent(HashMap.java:1128)
It seems to be related to the test setup, not the test itself. It impacts Q1 & Q10 as they are the first 2 to run
it looks like the native workers crashed.

@mshang816 I don't think so. If workers crash, the following 97 queries should fail but it succeeds in this case.

Are you able to reproduce this failure locally? presto-e2e-test still fails after disabling the test in #19932

frankobe requested review from a team as code owners May 13, 2023 01:11

frankobe requested a review from ajaygeorge May 13, 2023 01:11

frankobe marked this pull request as draft May 13, 2023 01:21

frankobe force-pushed the tpcds-parquet branch 3 times, most recently from e170f2c to 7b5a676 Compare May 15, 2023 19:28

frankobe changed the title ~~Tpcds parquet~~ [Native] Enable Tpcds Test for Parquet File May 16, 2023

frankobe force-pushed the tpcds-parquet branch 6 times, most recently from 1cee7dd to 3fe46ae Compare May 23, 2023 00:49

frankobe force-pushed the tpcds-parquet branch 3 times, most recently from a77ac5c to f1be2cd Compare May 25, 2023 19:14

frankobe force-pushed the tpcds-parquet branch from f1be2cd to 78e18cd Compare June 1, 2023 18:04

frankobe force-pushed the tpcds-parquet branch 2 times, most recently from cd67915 to f35deb3 Compare June 13, 2023 18:45

aditi-pandit reviewed Jun 13, 2023

View reviewed changes

...-native-execution/src/test/java/com/facebook/presto/nativeworker/NativeQueryRunnerUtils.java Outdated Show resolved Hide resolved

aditi-pandit reviewed Jun 13, 2023

View reviewed changes

...execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeTpcdsQueries.java Outdated Show resolved Hide resolved

frankobe force-pushed the tpcds-parquet branch 2 times, most recently from f6f9068 to 5dddbba Compare June 14, 2023 20:45

frankobe marked this pull request as ready for review June 14, 2023 22:40

frankobe force-pushed the tpcds-parquet branch 3 times, most recently from fb1e3f9 to e865257 Compare June 20, 2023 01:36

[Native] Add TPC-DS for parquet in presto-native-execution

2987ba1

Signed-off-by: frankobe <mua08p@gmail.com>

frankobe force-pushed the tpcds-parquet branch from e865257 to 2987ba1 Compare June 20, 2023 02:46

frankobe requested a review from aditi-pandit June 20, 2023 21:40

aditi-pandit approved these changes Jun 21, 2023

View reviewed changes

aditi-pandit merged commit 3b26dcd into prestodb:master Jun 21, 2023

This was referenced Jun 22, 2023

[native] Disable TestPrestoNativeTpcdsQueriesParquetUsingThrift #19932

Closed

[native] Add TPC-DS Tests for Dwarf & Parquet #18614

Closed

wanglinsong mentioned this pull request Jul 27, 2023

Add release notes for 0.283 #20402

Merged

28 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Native] Enable Tpcds Test for Parquet File#19646

[Native] Enable Tpcds Test for Parquet File#19646
aditi-pandit merged 1 commit intoprestodb:masterfrom
frankobe:tpcds-parquet

frankobe commented May 13, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

aditi-pandit left a comment

Uh oh!

mshang816 commented Jun 22, 2023

Uh oh!

frankobe commented Jun 22, 2023

Uh oh!

frankobe commented Jun 22, 2023

Uh oh!

mshang816 commented Jun 22, 2023

Uh oh!

mshang816 commented Jun 22, 2023

Uh oh!

frankobe commented Jun 22, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

frankobe commented May 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aditi-pandit left a comment

Choose a reason for hiding this comment

Uh oh!

mshang816 commented Jun 22, 2023

Uh oh!

frankobe commented Jun 22, 2023

Uh oh!

frankobe commented Jun 22, 2023

Uh oh!

mshang816 commented Jun 22, 2023

Uh oh!

mshang816 commented Jun 22, 2023

Uh oh!

frankobe commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

frankobe commented May 13, 2023 •

edited

Loading

frankobe commented Jun 22, 2023 •

edited

Loading