Skip to content

[native] Add TPC-DS Tests for Dwarf & Parquet#18614

Closed
frankobe wants to merge 1 commit intoprestodb:masterfrom
frankobe:tpcds_test
Closed

[native] Add TPC-DS Tests for Dwarf & Parquet#18614
frankobe wants to merge 1 commit intoprestodb:masterfrom
frankobe:tpcds_test

Conversation

@frankobe
Copy link
Contributor

@frankobe frankobe commented Nov 3, 2022

Added TestHiveTpcdsQueries to test results on 103 on both dwrf & parquet format.

In the sqls, decimal is cast to double
In the table creation, char(x) is cast to varchar

Signed-off-by: frankobe mua08p@gmail.com

== NO RELEASE NOTE ==

@frankobe frankobe requested review from a team as code owners November 3, 2022 05:24
@frankobe frankobe requested a review from presto-oss November 3, 2022 05:24
@frankobe frankobe marked this pull request as draft November 3, 2022 05:24
@frankobe frankobe force-pushed the tpcds_test branch 3 times, most recently from 0ef5fae to acddc05 Compare November 3, 2022 06:12
@frankobe frankobe changed the title Add test for presto_cpp tpcds [native] Add Tpc-ds Test for Dwarf & Parquet Nov 3, 2022
@frankobe frankobe changed the title [native] Add Tpc-ds Test for Dwarf & Parquet [native] Add TPC-DS Tests for Dwarf & Parquet Nov 3, 2022
@frankobe frankobe marked this pull request as ready for review November 3, 2022 17:23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dates work with Parquet. Would be nice to avoid the casts for Parquet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditi-pandit do u know whether dwrf supports date?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. dwrf does not support date.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit : Spelling "DWRF"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Dwrf" spelling in file name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit : spelling Dwrf

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling DWRF

Signed-off-by: frankobe <mua08p@gmail.com>
@v-jizhang
Copy link
Contributor

@bot kick off tests

@isadikov
Copy link
Contributor

isadikov commented May 2, 2023

I am following up on this.

@frankobe
Copy link
Contributor Author

Close in favor of #19646

@frankobe frankobe closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants