Skip to content

[native] Disable TestPrestoNativeTpcdsQueriesParquetUsingThrift#19932

Closed
mshang816 wants to merge 1 commit intoprestodb:masterfrom
mshang816:disable_new_parquet_test
Closed

[native] Disable TestPrestoNativeTpcdsQueriesParquetUsingThrift#19932
mshang816 wants to merge 1 commit intoprestodb:masterfrom
mshang816:disable_new_parquet_test

Conversation

@mshang816
Copy link
Contributor

@mshang816 mshang816 commented Jun 22, 2023

Disable the flaky TestPrestoNativeTpcdsQueriesParquetUsingThrift

Test plan - (Please fill in how you tested your changes)

Make sure all CI runs are green

== NO RELEASE NOTE ==

@mshang816 mshang816 requested a review from a team as a code owner June 22, 2023 00:28
@mshang816 mshang816 changed the title Ignore TestPrestoNativeTpcdsQueriesParquetUsingThrift [native] Ignore TestPrestoNativeTpcdsQueriesParquetUsingThrift Jun 22, 2023
@mshang816 mshang816 force-pushed the disable_new_parquet_test branch from 4e07c8b to d640511 Compare June 22, 2023 00:44
@mshang816 mshang816 changed the title [native] Ignore TestPrestoNativeTpcdsQueriesParquetUsingThrift [native] Disable TestPrestoNativeTpcdsQueriesParquetUsingThrift Jun 22, 2023
@mshang816 mshang816 force-pushed the disable_new_parquet_test branch from d640511 to 1f9a743 Compare June 22, 2023 01:37
@frankobe frankobe mentioned this pull request Jun 22, 2023
Merged
mbasmanova
mbasmanova reviewed Jun 22, 2023
View reviewed changes
...st/java/com/facebook/presto/nativeworker/TestPrestoNativeTpcdsQueriesParquetUsingThrift.java
import com.facebook.presto.testing.QueryRunner;
import org.testng.annotations.Ignore;

@Ignore
Copy link
Contributor

@mbasmanova mbasmanova Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mshang816 .

It would be nice to file GitHub issue to explain that this test is failing and share a stacktrace / error message, then add a comment here and refer to that issue.

typo in commit message: [nateive] -> [native]

@mbasmanova
Copy link
Contributor

mbasmanova commented Jun 22, 2023

ci/circleci: linux-presto-e2e-tests is failing. CC: @amitkdutta

@frankobe
Copy link
Contributor

frankobe commented Jun 22, 2023

Move the discussion from #19646 (comment) to here.

I suspect disabling TestPrestoNativeTpcdsQueriesParquetUsingThrift won't fix the flakiness of linux-presto-e2e-tests. I see similar failures due to com.facebook.presto.spi.PrestoException: No worker nodes available or sortedCandidates is null or empty for ModularHashingNodeProvider from other tests like but not limited to

Failures: 
[ERROR]   TestPrestoNativeAggregations>AbstractTestNativeAggregations.testAggregations:99
[ERROR]   TestPrestoNativeJoinQueries>AbstractTestNativeJoinQueries.testInnerJoin:55
[ERROR]   TestPrestoNativeWindowQueries>AbstractTestNativeWindowQueries.testRowNumberWithFilter:113

Failures: 
[ERROR]   TestPrestoNativeGeneralQueriesJSON>AbstractTestNativeGeneralQueries.testArrayAndMapFunctions:682
[ERROR]   TestPrestoNativeGeneralQueriesJSON>AbstractTestNativeGeneralQueries.testShowAndDescribe:795

The worker node shouldn't crash or the following tests can't pass so I wonder whether there is a way to check the availability of worker ports

@mshang816 mshang816 closed this Jun 22, 2023
@pratyakshsharma pratyakshsharma mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbasmanova mbasmanova mbasmanova left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mshang816 @mbasmanova @frankobe