Add Hive S3 tests for comma and pipe delimited CSVs#18786
Merged
pettyjamesm merged 1 commit intoprestodb:masterfrom Jan 10, 2023
Merged
Add Hive S3 tests for comma and pipe delimited CSVs#18786pettyjamesm merged 1 commit intoprestodb:masterfrom
pettyjamesm merged 1 commit intoprestodb:masterfrom
Conversation
Implement method for table filtering in utility class. Add extra tests for S3 Select pushdown for Hive connector.
f391dde to
1eeb3f1
Compare
This was referenced Jan 5, 2023
pettyjamesm
approved these changes
Jan 10, 2023
Contributor
pettyjamesm
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the additional tests!
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
Locally ran tests:
Rebased on master to include #18779 changes.