Refactor before JSON support for S3 Select pushdown in Hive connector#18798
Merged
pettyjamesm merged 1 commit intoprestodb:masterfrom Jan 19, 2023
Merged
Conversation
dnanuti
changed the title
Author
|
@pettyjamesm FYI 😄 |
dnanuti
force-pushed
the
refactor-before-json-support
branch
from
4bf7a0e to
f5161fe
Compare
This was referenced Jan 5, 2023
dnanuti
force-pushed
the
refactor-before-json-support
branch
3 times, most recently
from
4d10f67 to
817cbd6
Compare
dnanuti
changed the title
dnanuti
requested review from
a team,
7c00,
shangxinli and
vinothchandar
as code owners
dnanuti
force-pushed
the
refactor-before-json-support
branch
6 times, most recently
from
b5d9dab to
95ab7e3
Compare
pettyjamesm
reviewed
Jan 19, 2023
Contributor
pettyjamesm
left a comment
pettyjamesm
left a comment
There was a problem hiding this comment.
Minor comments, otherwise LGTM.
presto-hive/src/test/java/com/facebook/presto/hive/HiveTestUtils.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/AbstractTestHiveFileSystem.java
Outdated
Show resolved
Hide resolved
dnanuti
force-pushed
the
refactor-before-json-support
branch
from
32f63c1 to
f53ff38
Compare
Add S3SelectDataType and S3SelectSerDeDataTypeMapper and refactor S3SelectLineRecordReader and S3SelectCsvRecordReader in preparation for adding JSON support.
dnanuti
force-pushed
the
refactor-before-json-support
branch
from
f53ff38 to
c3ed83c
Compare
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add S3SelectDataType and S3SelectSerDeDataTypeMapper and refactor S3SelectLineRecordReader and S3SelectCsvRecordReader in preparation for adding JSON support for S3 Select pushdown in Hive connector.