Merged
Conversation
Author
|
@pettyjamesm please have a look on this when you find the time |
fuatbasik
approved these changes
Dec 8, 2022
dnanuti
force-pushed
the
s3-select-tests
branch
2 times, most recently
from
160afd0 to
bb6360a
Compare
dnanuti
force-pushed
the
s3-select-tests
branch
3 times, most recently
from
58ae4de to
8fbc53f
Compare
dnanuti
force-pushed
the
s3-select-tests
branch
2 times, most recently
from
452abb1 to
456b7d1
Compare
pettyjamesm
approved these changes
Dec 13, 2022
Contributor
There was a problem hiding this comment.
Neat shortcut. I guess we don't really need the specific -copyFromLocal semantics enforced here
dnanuti
force-pushed
the
s3-select-tests
branch
from
456b7d1 to
c40e207
Compare
Move common methods for Hive File System tests setup to utility class. Add more test cases for S3 Select Pushdown enabling.
dnanuti
force-pushed
the
s3-select-tests
branch
from
c40e207 to
cd67349
Compare
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move common methods for Hive File System tests setup to utility class.
Add more test cases in TestS3SelectPushdown.
More tests to be added, but I try to keep the PRs small for an easier review.
Test plan - (Please fill in how you tested your changes)
Locally run
./presto-hive-hadoop2/bin/run_hive_s3_tests.shin Docker container and TestS3SelectPushdown unit tests.Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.