Skip to content

[native] Add TPC-DS Tests for Dwarf & Parquet #18614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frankobe wants to merge 1 commit into from
Closed

[native] Add TPC-DS Tests for Dwarf & Parquet #18614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
ccache -sz -M 8Gi
source /opt/rh/gcc-toolset-9/enable
cd presto-native-execution
cmake -B _build/debug -GNinja -DTREAT_WARNINGS_AS_ERRORS=1 -DENABLE_ALL_WARNINGS=1 -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=/usr/local -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
cmake -B _build/debug -GNinja -DTREAT_WARNINGS_AS_ERRORS=1 -DENABLE_ALL_WARNINGS=1 -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=/usr/local -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DPRESTO_ENABLE_PARQUET=ON
ninja -C _build/debug -j 8
ccache -s
- save_cache:
Expand Down
374 changes: 365 additions & 9 deletions ...ative-execution/src/test/java/com/facebook/presto/hive/HiveExternalWorkerQueryRunner.java
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 8 additions & 3 deletions ...ive-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestHiveQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,16 @@
public class AbstractTestHiveQueries
extends AbstractTestQueryFramework
{
static final String PARQUET_STORAGE_FORMAT = "PARQUET";
static final String DWARF_STORAGE_FORMAT = "DWRF";

private final boolean useThrift;
private final String storageFormat;

protected AbstractTestHiveQueries(boolean useThrift)
protected AbstractTestHiveQueries(boolean useThrift, String storageFormat)
{
this.useThrift = useThrift;
this.storageFormat = storageFormat;
}

@Override
Expand All @@ -45,14 +50,14 @@ protected QueryRunner createQueryRunner()
assertNotNull(prestoServerPath, "Native worker binary path is missing. Add -DPRESTO_SERVER=<path/to/presto_server> to your JVM arguments.");
assertNotNull(dataDirectory, "Data directory path is missing. Add -DDATA_DIR=<path/to/data> to your JVM arguments.");

return HiveExternalWorkerQueryRunner.createNativeQueryRunner(dataDirectory, prestoServerPath, Optional.ofNullable(workerCount).map(Integer::parseInt), cacheMaxSize, useThrift);
return HiveExternalWorkerQueryRunner.createNativeQueryRunner(dataDirectory, prestoServerPath, Optional.ofNullable(workerCount).map(Integer::parseInt), cacheMaxSize, useThrift, storageFormat);
}

@Override
protected ExpectedQueryRunner createExpectedQueryRunner()
throws Exception
{
String dataDirectory = System.getProperty("DATA_DIR");
return HiveExternalWorkerQueryRunner.createJavaQueryRunner(Optional.of(Paths.get(dataDirectory)));
return HiveExternalWorkerQueryRunner.createJavaQueryRunner(Optional.of(Paths.get(dataDirectory)), storageFormat);
}
}
2 changes: 1 addition & 1 deletion ...-execution/src/test/java/com/facebook/presto/nativeworker/TestHiveAggregationQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class TestHiveAggregationQueries
{
public TestHiveAggregationQueries()
{
super(true);
super(true, DWARF_STORAGE_FORMAT);
Copy link
Copy Markdown
Contributor

@aditi-pandit aditi-pandit Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit : Spelling "DWRF"

}

@Test
Expand Down
2 changes: 1 addition & 1 deletion ...cution/src/test/java/com/facebook/presto/nativeworker/TestHiveBitwiseFunctionQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class TestHiveBitwiseFunctionQueries
{
public TestHiveBitwiseFunctionQueries()
{
super(false);
super(false, DWARF_STORAGE_FORMAT);
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion ...-native-execution/src/test/java/com/facebook/presto/nativeworker/TestHiveJoinQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class TestHiveJoinQueries
{
public TestHiveJoinQueries()
{
super(true);
super(true, DWARF_STORAGE_FORMAT);
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/src/test/java/com/facebook/presto/nativeworker/TestHiveQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ abstract class TestHiveQueries
{
protected TestHiveQueries(boolean useThrift)
{
super(useThrift);
super(useThrift, DWARF_STORAGE_FORMAT);
}

@Test
Expand Down
Loading