Fix close idempotency for JDBC PreparedStatement#17639
Merged
highker merged 1 commit intoprestodb:masterfrom Apr 20, 2022
axiomq:backport/fix_close_idempotency_for_jdbc_preparedstatement
Merged
Fix close idempotency for JDBC PreparedStatement#17639highker merged 1 commit intoprestodb:masterfrom axiomq:backport/fix_close_idempotency_for_jdbc_preparedstatement
highker merged 1 commit intoprestodb:masterfrom
axiomq:backport/fix_close_idempotency_for_jdbc_preparedstatement
Conversation
presto-jdbc/src/main/java/com/facebook/presto/jdbc/PrestoPreparedStatement.java
Outdated
Show resolved
Hide resolved
Contributor
|
There is a style check error. No need to explicitly set isClosed = false. We can just |
NikhilCollooru
approved these changes
Apr 19, 2022
highker
approved these changes
Apr 19, 2022
|
Can we squash all commits into one? Also, can we cap the commit message upto 72 characters per line. |
Fix the behavior of PreparedStatement.close() so that it may be called multiple times without throwing an exception on subsequent invocations, which is required per the JDBC specification: ``` Calling the method close on a Statement object that is already closed has no effect. ``` Cherry-pick of trinodb/trino#11620 Co-authored-by: David Phillips <david@acz.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the behavior of PreparedStatement.close() so that it may be called
multiple times without throwing an exception on subsequent invocations,
which is required per the JDBC specification:
Cherry-pick of trinodb/trino#11620
Co-authored-by: David Phillips david@acz.org
Test plan - Added Unit Tests