Skip to content

Fix close idempotency for JDBC PreparedStatement #17639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
highker merged 1 commit into from
Apr 20, 2022
Merged

Fix close idempotency for JDBC PreparedStatement #17639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions presto-jdbc/src/main/java/com/facebook/presto/jdbc/PrestoPreparedStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public class PrestoPreparedStatement
private final Map<Integer, String> parameters = new HashMap<>();
private final String statementName;
private final String originalSql;
private boolean isClosed;

PrestoPreparedStatement(PrestoConnection connection, String statementName, String sql)
throws SQLException
Expand All @@ -88,8 +89,12 @@ public class PrestoPreparedStatement
public void close()
throws SQLException
{
if (isClosed) {
return;
}
super.execute(format("DEALLOCATE PREPARE %s", statementName));
super.close();
isClosed = true;
}

@Override
Expand Down
11 changes: 11 additions & 0 deletions presto-jdbc/src/test/java/com/facebook/presto/jdbc/TestJdbcPreparedStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,17 @@ public void testDeallocate()
}
}

@Test
public void testCloseIdempotency()
throws Exception
{
try (Connection connection = createConnection()) {
PreparedStatement statement = connection.prepareStatement("SELECT 123");
statement.close();
statement.close();
}
}

@Test
public void testExecuteUpdate()
throws Exception
Expand Down