Fix close idempotency for JDBC PreparedStatement#11620
Merged
electrum merged 2 commits intotrinodb:masterfrom Mar 23, 2022
Merged
Fix close idempotency for JDBC PreparedStatement#11620electrum merged 2 commits intotrinodb:masterfrom
electrum merged 2 commits intotrinodb:masterfrom
Conversation
dain
approved these changes
Mar 23, 2022
client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoPreparedStatement.java
Outdated
Show resolved
Hide resolved
Per the JDBC specification: When a Statement object is closed, its current ResultSet object, if one exists, is also closed.
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Apr 6, 2022
Cherry-pick of trinodb/trino#11620 Fix the behavior of PreparedStatement.close() so that it may be called multiple times without throwing an exception on subsequent invocations, which is required per the JDBC specification: Calling the method close on a Statement object that is already closed has no effect. Co-authored-by: David Phillips <david@acz.org>
highker
pushed a commit
to prestodb/presto
that referenced
this pull request
Apr 20, 2022
Fix the behavior of PreparedStatement.close() so that it may be called multiple times without throwing an exception on subsequent invocations, which is required per the JDBC specification: ``` Calling the method close on a Statement object that is already closed has no effect. ``` Cherry-pick of trinodb/trino#11620 Co-authored-by: David Phillips <david@acz.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the behavior of
PreparedStatement.close()so that it may be called multiple times without throwing an exception on subsequent invocations, which is required per the JDBC specification:Documentation
(x) No documentation is needed.
Release notes
(x) Release notes entries required with the following suggested text: