Enable ctas with unmanaged hive table

[rguillome]

Test plan - TU to create an table as a select with an external location with presto-hive plugin and a manual TI to test the creation under EMR, using a Glue catalog and seeing the results in S3 and Athena

This PR allow the creation of an unmanaged table (with external location specified) as a select result (CTAS) with Hive Plugin

Co-authored-by: alexjo2144 [email protected]

Fix:
#15946

Based on
trino PR #2669
trino PR #3755

== RELEASE NOTES ==

Hive Changes
* Add ability to create table with an external location when the catalog configuration 
  ``hive.non-managed-table-creates-enabled`` and ``hive.non-managed-table-writes-enabled`` set to ``true``

[v-jizhang]

@rguillome This is cherry pick of trinodb/trino#3755 and trinodb/trino#2669. Please add co-author. Thanks

[v-jizhang]

LGTM

[rguillome]

Hi @v-jizhang

This PR is still waiting approval and I just saw another PR with the same purpose (#16147).
Is this one won't be merged anymore ?

[ashishtadose]

Hi @v-jizhang

This PR is still waiting approval and I just saw another PR with the same purpose (#16147).
Is this one won't be merged anymore ?

Hi @rguillome, we happened to address this recently in our distro so I raised a PR not knowing there's already some WIP on this. I will close the other PR.

[rguillome]

Thanks @ashishtadose !
I hoped one of them would be approved in few days no matter what the contributor is. I have a tool release waiting for this since some weeks.

[ajaygeorge]

@rguillome Please squash the 6 commits in the PR (some of them are merge commits)
Also refer to Release Notes wiki : https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines
The current PR release notes does not match what we need.

[rguillome]

Hi @ajaygeorge
I made all the changes: Hope this is ok now 😏

[rguillome]

Hi @ajaygeorge,

Please let me know what's why Facebook integration is failing (I thought I have seen succeed a day before...) and what's missing/wrong about this PR.

[ajaygeorge]

@rguillome can you try triggering the build again by doing an git amend and push with no changes.
I think there were some permission issues which was causing errors.

[rguillome]

Hi @ajaygeorge ,

I made the push force 5 days ago with no more luck.

Regards,

[ajaygeorge]

@cocozianu can you please take a look at why the facebook integration build is not working. Looks like a new build is not getting fired for this PR.

[rguillome]

Hi @ajaygeorge and @cocozianu

There is still a facebook integration error on this PR. Please let me know if I can change something to help going through this step.

Regards,

[cocozianu]

Hi @rguillome it's cleared now, sorry for the inconvenience.

[rguillome]

Hi @cocozianu : what's the next step for this PR, how can it be handled to be merged ?

Regards,

[rguillome]

Hi @cocozianu : what's the next step for this PR, how can it be handled to be merged ?

Regards,

Please up !

[rguillome]

Hi @ajaygeorge and @cocozianu

Is there any chance this PR would be integrated soon ?

[rohanpednekar]

@aweisberg Do you think we can merge for the next release if it looks good to you as well?

[rguillome]

Hi there,

Happy new year to Presto's team 🎉

Is there a chance that PR would be merge ? Time is passing and I would like to avoid maintaining a fork with work to integrate incoming changes in my current production version of PrestoSQL

Please let me know what do you plan for it

Regards

[aweisberg]

This doesn't bring in all of the tests from Trino so maybe we should go with #16147?

[rguillome]

This doesn't bring in all of the tests from Trino so maybe we should go with #16147?

As mentionned in the PR first comment, it was deliberate since a CTAS is a table creation from query results and not writing to an existing table but perhaps it's better to stick to trino's view.

I will close this one and go to the #16147

[rguillome]

This doesn't bring in all of the tests from Trino so maybe we should go with #16147?

As mentionned in the PR first comment, it was deliberate since a CTAS is a table creation from query results and not writing to an existing table but perhaps it's better to stick to trino's view.

I will close this one and go to the #16147

Hi @aweisberg,

As the other PR #16147 introducing CTAS has not changed since your last comment, I managed to make this one compliant with the missings tests (there is one test more than the #16147 in the product-test module).

Rebase to the current master has been made too.
Please let me know if there is anything missing yet.

[rohanpednekar]

Hey @yingsu00, could you please help with the final revive and get this merged? Thanks!

[rguillome]

Hi, any news from this one please ?

[prestoprobot]

@yingsu00 Friendly ping. Please review this PR. Thank you!

[rguillome]

Hi,
it's been a long time now. Let me know if there is a chance that it would be merged...