Allow for CTAS table creation to external tables when write are enabled #2669
Conversation
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveCreateExternalTables.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveCreateExternalTables.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveCreateExternalTables.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveCreateExternalTables.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveCreateExternalTables.java
Outdated
Show resolved
Hide resolved
|
Good job, a bunch of editorial comments. |
There was a problem hiding this comment.
LGTM
@alexjo2144 could you please squash the commits now, without rebasing on current master?
on the command line, git rebase --interactive $(git merge-base HEAD master) should do the trick.
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveCreateExternalTable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
One more thing, I think here we should check both: writesToNonManagedTablesEnabled and createsOfNonManagedTablesEnabled
There was a problem hiding this comment.
You're right, but any idea why that case isn't being caught by https://github.com/prestosql/presto/blob/master/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java#L789
There was a problem hiding this comment.
AFAIR that place is only for create without data (one-off create)
and this code is only for create with data (prepare-write-commit)
alexjo2144
force-pushed
the
create-external-table-as
branch
from
66d90fb to
f3ef1a3
Compare
|
Rebased, added the create external tables enabled check, and added a few more tests to cover the case for writes enabled but creates disabled. |
…tes are enabled. When hive.non-managed-table-writes-enabled and hive.non-managed-table-creates-enabled are both set to true, external tables can be created and inserted into. This change allows for that to be done in one step using the `CREATE TABLE AS` syntax.
alexjo2144
force-pushed
the
create-external-table-as
branch
from
f3ef1a3 to
855a9d2
Compare
|
Merged, thanks! |
3 participants
Duplicates #2556 with tests added.
When
hive.non-managed-table-writes-enabledandhive.non-managed-table-creates-enabledare both set to true, external tables can be created and inserted into. This change
allows for that to be done in one step using the
CREATE TABLE ASsyntax.