Skip to content

Enable ctas with unmanaged hive table #15990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable ctas with unmanaged hive table #15990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8331f3f
add CTAS with external location specified
rguillome Apr 19, 2021
b80eeec
add missing tests from Trino backport of CTAS
rguillome Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions presto-hive/src/main/java/com/facebook/presto/hive/HiveLocationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
import static com.facebook.presto.hive.LocationHandle.WriteMode.DIRECT_TO_TARGET_EXISTING_DIRECTORY;
import static com.facebook.presto.hive.LocationHandle.WriteMode.DIRECT_TO_TARGET_NEW_DIRECTORY;
import static com.facebook.presto.hive.LocationHandle.WriteMode.STAGE_AND_MOVE_TO_TARGET_DIRECTORY;
import static com.facebook.presto.hive.metastore.MetastoreUtil.createDirectory;
import static com.facebook.presto.hive.metastore.MetastoreUtil.pathExists;
import static java.lang.String.format;
import static java.util.Objects.requireNonNull;
Expand All @@ -55,16 +54,16 @@ public HiveLocationService(HdfsEnvironment hdfsEnvironment)
}

@Override
public LocationHandle forNewTable(SemiTransactionalHiveMetastore metastore, ConnectorSession session, String schemaName, String tableName, boolean tempPathRequired)
public LocationHandle forNewTable(SemiTransactionalHiveMetastore metastore, ConnectorSession session, String schemaName, String tableName, boolean tempPathRequired, Optional<Path> externalLocation)
{
Path targetPath = getTableDefaultLocation(session, metastore, hdfsEnvironment, schemaName, tableName);
Path targetPath = externalLocation.orElseGet(() -> getTableDefaultLocation(session, metastore, hdfsEnvironment, schemaName, tableName));

HdfsContext context = new HdfsContext(session, schemaName, tableName, targetPath.toString(), true);
// verify the target directory for the table
if (pathExists(context, hdfsEnvironment, targetPath)) {
throw new PrestoException(HIVE_PATH_ALREADY_EXISTS, format("Target directory for table '%s.%s' already exists: %s", schemaName, tableName, targetPath));
}
return createLocationHandle(context, session, targetPath, NEW, tempPathRequired);
return createLocationHandle(context, session, targetPath, NEW, tempPathRequired, externalLocation);
}

@Override
Expand All @@ -73,7 +72,7 @@ public LocationHandle forExistingTable(SemiTransactionalHiveMetastore metastore,
String tablePath = table.getStorage().getLocation();
HdfsContext context = new HdfsContext(session, table.getDatabaseName(), table.getTableName(), tablePath, false);
Path targetPath = new Path(tablePath);
return createLocationHandle(context, session, targetPath, EXISTING, tempPathRequired);
return createLocationHandle(context, session, targetPath, EXISTING, tempPathRequired, Optional.empty());
}

@Override
Expand All @@ -91,12 +90,12 @@ public LocationHandle forTemporaryTable(SemiTransactionalHiveMetastore metastore
DIRECT_TO_TARGET_NEW_DIRECTORY);
}

private LocationHandle createLocationHandle(HdfsContext context, ConnectorSession session, Path targetPath, TableType tableType, boolean tempPathRequired)
private LocationHandle createLocationHandle(HdfsContext context, ConnectorSession session, Path targetPath, TableType tableType, boolean tempPathRequired, Optional<Path> externalLocation)
{
Optional<Path> tempPath = tempPathRequired ? Optional.of(createTemporaryPath(session, context, hdfsEnvironment, targetPath)) : Optional.empty();
if (shouldUseTemporaryDirectory(session, context, targetPath)) {

if (shouldUseTemporaryDirectory(session, context, targetPath, externalLocation)) {
Path writePath = createTemporaryPath(session, context, hdfsEnvironment, targetPath);
createDirectory(context, hdfsEnvironment, writePath);
return new LocationHandle(targetPath, writePath, tempPath, tableType, STAGE_AND_MOVE_TO_TARGET_DIRECTORY);
}
if (tableType.equals(EXISTING)) {
Expand All @@ -105,11 +104,13 @@ private LocationHandle createLocationHandle(HdfsContext context, ConnectorSessio
return new LocationHandle(targetPath, targetPath, tempPath, tableType, DIRECT_TO_TARGET_NEW_DIRECTORY);
}

private boolean shouldUseTemporaryDirectory(ConnectorSession session, HdfsContext context, Path path)
private boolean shouldUseTemporaryDirectory(ConnectorSession session, HdfsContext context, Path path, Optional<Path> externalLocation)
{
return isTemporaryStagingDirectoryEnabled(session)
// skip using temporary directory for S3
&& !isS3FileSystem(context, hdfsEnvironment, path);
&& !isS3FileSystem(context, hdfsEnvironment, path)
// Skip using temporary directory if destination is external. Target may be on a different file system.
&& !externalLocation.isPresent();
}

@Override
Expand Down
Loading