Skip to content

[Deprecated] Backport "Parquet dynamic batch size"#13350

Closed
achopragh wants to merge 4 commits intoprestodb:masterfrom
achopragh:task2
Closed

[Deprecated] Backport "Parquet dynamic batch size"#13350
achopragh wants to merge 4 commits intoprestodb:masterfrom
achopragh:task2

Conversation

@achopragh
Copy link
Copy Markdown
Contributor

@achopragh achopragh commented Sep 6, 2019

Resolves #12503

Hive Connector Changes
===================
Reduce GC pressure from Parquet reader by constraining the maximum column read size. 

@wenleix
Copy link
Copy Markdown
Contributor

wenleix commented Sep 9, 2019

@achopragh : Is this the second commit of trinodb/trino#58? Can you have the two commits in #13342 ? (i.e. one PR with two commits that )

@wenleix
Copy link
Copy Markdown
Contributor

wenleix commented Sep 10, 2019

Quick comments:

Commits cherry-picked from other projects must have their original author field preserved including the name and email address as it appears in git-log in the original repository. The person cherry-picking the commit should add themselves as a co-author using GitHub’s multiple author functionality unless they are a committing themselves. When merging together multiple external commits include as many co-authors as necessary to capture all the contributors.

When committing locally you can use --author="First Last foo@example.com" where you cut and paste the author information from the original commit. You can use interactive rebase to edit existing commits and correct author information on your branch.

@ajaygeorge recently also did a backport a PR and go through these commit message / author settings. Feel free to reach out to @ajaygeorge or me if you need any help in terms of backport (and update the commit guideline if you found anything unclear~ :) )

@wenleix wenleix changed the title Part 2 of the Parquet dynamic batch size #58 Backport "Parquet dynamic batch size" Sep 10, 2019
@zhenxiao
Copy link
Copy Markdown
Collaborator

Hi @achopragh thanks for working on it.
could you please keep original author, and add you as a co-author in the commit message?

@ajaygeorge
Copy link
Copy Markdown
Contributor

Hi @achopragh, Thank you for contributing !.
As @zhenxiao and @wenleix was mentioning we tend to keep the original commit message and author in tact when we backport so that it is easier to review and the original authors are properly attributed.

You can use this command for attributing commits to the original author :
git commit --amend --author="First Last foo@example.com"

The commit message can be amended to adhere to the standard we have mentioned here

Fix OOM caused by foo in bar

Foo was pack ratting ByteBuffers causing OOM.

Cherry-pick of https://github.com/foo/bar/pull/123 (https://github.com/foo/bar/pull/123)

Co-authored-by: Foo Bar <foo@bar.com>

Please let us know if you have any questions.

@wenleix
Copy link
Copy Markdown
Contributor

wenleix commented Sep 25, 2019

Close this in favor for #13393

@wenleix wenleix closed this Sep 25, 2019
@wenleix wenleix changed the title Backport "Parquet dynamic batch size" [Deprecated] Backport "Parquet dynamic batch size" Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backport prestosql/presto#58

5 participants