Parquet dynamic batch size#58
Merged
dain merged 2 commits intotrinodb:masterfrom Jan 31, 2019
luohao:hluo/parquet-dynamic-batch-size
Merged
Parquet dynamic batch size#58dain merged 2 commits intotrinodb:masterfrom luohao:hluo/parquet-dynamic-batch-size
dain merged 2 commits intotrinodb:masterfrom
luohao:hluo/parquet-dynamic-batch-size
Conversation
dain
requested changes
Jan 30, 2019
Member
dain
left a comment
dain
left a comment
There was a problem hiding this comment.
Some very minor suggestions, but otherwise looks great.
presto-hive/src/main/java/io/prestosql/plugin/hive/HiveSessionProperties.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/parquet/ParquetTester.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/parquet/ParquetTester.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/parquet/ParquetTester.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/parquet/ParquetTester.java
Outdated
Show resolved
Hide resolved
presto-parquet/src/main/java/io/prestosql/parquet/reader/ParquetReader.java
Outdated
Show resolved
Hide resolved
presto-parquet/src/main/java/io/prestosql/parquet/reader/ParquetReader.java
Outdated
Show resolved
Hide resolved
presto-parquet/src/main/java/io/prestosql/parquet/reader/ParquetReader.java
Outdated
Show resolved
Hide resolved
dain
requested changes
Jan 30, 2019
Member
There was a problem hiding this comment.
One last formatting comment. Can you squash the first three commits, so we end up with just:
- Add dynamic batch sizing in Parquet reader
- Reformat ParquetTester
Also, please update the commit message as I have above (fix capitalization and remove the .java
presto-hive/src/test/java/io/prestosql/plugin/hive/parquet/ParquetTester.java
Outdated
Show resolved
Hide resolved
dain
approved these changes
Jan 30, 2019
achopragh
added a commit
to achopragh/presto
that referenced
this pull request
Sep 26, 2019
Cherry-pick of trinodb/trino#58 Co-authored-by: Amit Chopra <amitchopra@fb.com>
achopragh
added a commit
to achopragh/presto
that referenced
this pull request
Sep 27, 2019
Cherry-pick of trinodb/trino#58 Co-authored-by: Amit Chopra <amitchopra@fb.com>
wenleix
pushed a commit
to wenleix/presto
that referenced
this pull request
Sep 28, 2019
Cherry-pick of trinodb/trino#58 Co-authored-by: Amit Chopra <amitchopra@fb.com>
wenleix
pushed a commit
to prestodb/presto
that referenced
this pull request
Sep 28, 2019
Cherry-pick of trinodb/trino#58 Co-authored-by: Amit Chopra <amitchopra@fb.com>
kaikalur
pushed a commit
to kaikalur/presto
that referenced
this pull request
Jan 22, 2020
Cherry-pick of trinodb/trino#58 Co-authored-by: Amit Chopra <amitchopra@fb.com>
voonhous
pushed a commit
to voonhous/trino
that referenced
this pull request
Sep 8, 2025
…n column stats are enabled (trinodb#58) * Co-authored-by: Vamsi <vamsi@onehouse.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dynamic batch sizing based on max combined block size observed so far in Parquet reader.