Skip to content

[Deprecated] Backport "Add dynamic batch sizing in Parquet reader" #13342

Closed
achopragh wants to merge 1 commit intoprestodb:masterfrom
achopragh:FirstTast
Closed

[Deprecated] Backport "Add dynamic batch sizing in Parquet reader" #13342
achopragh wants to merge 1 commit intoprestodb:masterfrom
achopragh:FirstTast

Conversation

@achopragh
Copy link
Copy Markdown
Contributor

@achopragh achopragh commented Sep 5, 2019

Resolves #12503

== NO RELEASE NOTE ==

@wenleix
Copy link
Copy Markdown
Contributor

wenleix commented Sep 6, 2019

@achopragh Can you retain the original commit structure as in https://github.com/prestosql/presto/pull/58/commits ? -- i.e. two commits . This helps tracking the commit history.

Also please follow the commit guideline: https://github.com/prestodb/presto/wiki/Review-and-Commit-guidelines#commit-formatting-and-pull-requests to retain original author field. You can add yourself as co-author (https://help.github.com/en/articles/creating-a-commit-with-multiple-authors) :

Commits cherry-picked from other projects must have their original author field preserved including the name and email address as it appears in git-log in the original repository. The person cherry-picking the commit should add themselves as a co-author using GitHub’s multiple author functionality unless they are a committing themselves. When merging together multiple external commits include as many co-authors as necessary to capture all the contributors.

When committing locally you can use --author="First Last foo@example.com" where you cut and paste the author information from the original commit. You can use interactive rebase to edit existing commits and correct author information on your branch.

@wenleix
Copy link
Copy Markdown
Contributor

wenleix commented Sep 10, 2019

Per offline discussion, close this in favor for #13350

@wenleix wenleix closed this Sep 10, 2019
@wenleix wenleix changed the title Merging Commit "Add dynamic batch sizing in Parquet reader" for Parqu… [Deprecated] Backport "Add dynamic batch sizing in Parquet reader" Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backport prestosql/presto#58

3 participants