Skip to content

fix(global): relative windows --paths #4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hofer-Julian merged 3 commits into from
Aug 19, 2025
Merged

fix(global): relative windows --paths #4395

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29b5861
fix(global): relative windows --paths
baszalmstra Aug 19, 2025
4eb6080
Merge remote-tracking branch 'upstream' into feature/pxi-125-fix-recu…
Hofer-Julian Aug 19, 2025
51e5b81
Merge remote-tracking branch 'upstream' into feature/pxi-125-fix-recu…
Hofer-Julian Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions crates/pixi_cli/src/cli/global/global_specs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@ use std::path::Path;
use clap::Parser;
use miette::Diagnostic;
use pixi_consts::consts;
use typed_path::Utf8TypedPathBuf;
use url::Url;

use pixi_core::global::project::FromMatchSpecError;
use pixi_spec::PixiSpec;
use rattler_conda_types::{ChannelConfig, MatchSpec, ParseMatchSpecError, ParseStrictness};
use typed_path::Utf8NativePathBuf;
use url::Url;

use crate::cli::has_specs::HasSpecs;

Expand All @@ -32,7 +31,7 @@ pub struct GlobalSpecs {

/// The path to the local directory
#[clap(long, conflicts_with = "git")]
pub path: Option<Utf8TypedPathBuf>,
pub path: Option<Utf8NativePathBuf>,
}

impl HasSpecs for GlobalSpecs {
Expand Down Expand Up @@ -88,7 +87,8 @@ impl GlobalSpecs {
)
})?;
Some(PixiSpec::Path(pixi_spec::PathSpec {
path: Utf8TypedPathBuf::from(relative_path.to_string_lossy().to_string()),
path: Utf8NativePathBuf::from(relative_path.to_string_lossy().to_string())
.to_typed_path_buf(),
}))
} else {
None
Expand Down Expand Up @@ -131,9 +131,10 @@ impl GlobalSpecs {
mod tests {
use std::path::PathBuf;

use super::*;
use rattler_conda_types::ChannelConfig;

use super::*;

#[tokio::test]
async fn test_to_global_specs_named() {
let specs = GlobalSpecs {
Expand All @@ -147,7 +148,8 @@ mod tests {
let channel_config = ChannelConfig::default_with_root_dir(PathBuf::from("."));
let manifest_root = PathBuf::from(".");

// Create a dummy project - this test doesn't use path/git specs so project won't be called
// Create a dummy project - this test doesn't use path/git specs so project
// won't be called
let project = pixi_core::global::Project::discover_or_create()
.await
.unwrap();
Expand All @@ -173,7 +175,8 @@ mod tests {
let channel_config = ChannelConfig::default_with_root_dir(PathBuf::from("."));
let manifest_root = PathBuf::from(".");

// Create a dummy project - this test specifies a package name so inference won't be needed
// Create a dummy project - this test specifies a package name so inference
// won't be needed
let project = pixi_core::global::Project::discover_or_create()
.await
.unwrap();
Expand Down
Loading